Page MenuHomePhabricator
Create Task
Maniphest T220884

Update the DeletePagesForGood extension for MCR
Closed, ResolvedPublic
Actions

Description

Currently, the DeletePagesForGood extension still relies on rev_text_id and ar_text_id, which are fields that MCR will make obsolete. With MCR, the extension should instead delete rows from the slots and content tables, and use content_address to determine which rows should be deleted from the text table. Also, to reduce errors, the extension should check to see if a content_id will still be used by another row in the slots table after deleting the page's revisions, and if so, will not delete the corresponding rows from the content and text tables.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/DeletePagesForGoodmaster+137 -17Remove references to db fields rev_text_id and ar_text_id
mediawiki/extensions/DeletePagesForGoodmaster+117 -17Remove references to db fields rev_text_id and ar_text_id
Customize query in gerrit

Related Objects

Event Timeline

GeoffreyT2000 created this task.Apr 13 2019, 3:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2019, 3:31 PM
GeoffreyT2000 updated the task description. (Show Details)Apr 13 2019, 3:47 PM
Aklapper removed a project: Multi-Content-Revisions.Apr 13 2019, 5:09 PM

No code changes in Multi-Content-Revisions needed, hence removing tag.

Paladox added a subscriber: Paladox.Apr 13 2019, 5:16 PM
GeoffreyT2000 added a parent task: T198341: Remove all references to the rev_text_id and ar_text_id fields.Jul 12 2019, 12:37 AM
gerritbot added a comment.Jul 12 2019, 12:40 AM

Change 506573 had a related patch set uploaded (by BPirkle; owner: BPirkle):
[mediawiki/extensions/DeletePagesForGood@master] Remove references to db fields rev_text_id and ar_text_id

https://gerrit.wikimedia.org/r/506573

gerritbot added a project: Patch-For-Review.Jul 12 2019, 12:40 AM
BPirkle mentioned this in T198341: Remove all references to the rev_text_id and ar_text_id fields.Jul 12 2019, 2:39 AM
daniel removed a parent task: T198341: Remove all references to the rev_text_id and ar_text_id fields.Jul 17 2019, 10:58 AM
daniel added a subscriber: daniel.

Removed this as a blocker for T198341, since it's not deployed by WMF.

gerritbot added a comment.Mar 26 2020, 4:26 PM

Change 506573 abandoned by BPirkle:
Remove references to db fields rev_text_id and ar_text_id

Reason:
Extremely outdated

https://gerrit.wikimedia.org/r/506573

Maintenance_bot removed a project: Patch-For-Review.Mar 26 2020, 5:10 PM
Bugreporter merged a task: T267486: Cannot delete pages in MW 1.35: Unknown column 'rev_text_id' in 'field list'.Nov 8 2020, 2:35 PM
Bugreporter added a subscriber: GreyWolfling.
TiltedCerebellum added a subscriber: TiltedCerebellum.Nov 13 2020, 3:34 AM
Bugreporter mentioned this in T290099: Create a "delete me" maintenance script for special user/data deletion requests.Sep 2 2021, 4:25 PM
gerritbot added a comment.Mon, Sep 18, 5:31 PM

Change 958530 had a related patch set uploaded (by Seb35; author: BPirkle):

[mediawiki/extensions/DeletePagesForGood@master] Remove references to db fields rev_text_id and ar_text_id

https://gerrit.wikimedia.org/r/958530

gerritbot added a project: Patch-For-Review.Mon, Sep 18, 5:31 PM
gerritbot added a comment.Mon, Sep 18, 7:56 PM

Change 958530 merged by jenkins-bot:

[mediawiki/extensions/DeletePagesForGood@master] Remove references to db fields rev_text_id and ar_text_id

https://gerrit.wikimedia.org/r/958530

Seb35 mentioned this in rEDPG65d4c14590f8: Remove references to db fields rev_text_id and ar_text_id.Mon, Sep 18, 7:56 PM
Maintenance_bot removed a project: Patch-For-Review.Mon, Sep 18, 8:12 PM
Seb35 closed this task as Resolved.Tue, Sep 19, 3:46 PM
Seb35 assigned this task to BPirkle.
Seb35 added subscribers: BPirkle, Seb35.

Fixed by the patch 958530 of @BPirkle and myself.

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL