Page MenuHomePhabricator

Update the DeletePagesForGood extension for MCR
Closed, ResolvedPublic

Description

Currently, the DeletePagesForGood extension still relies on rev_text_id and ar_text_id, which are fields that MCR will make obsolete. With MCR, the extension should instead delete rows from the slots and content tables, and use content_address to determine which rows should be deleted from the text table. Also, to reduce errors, the extension should check to see if a content_id will still be used by another row in the slots table after deleting the page's revisions, and if so, will not delete the corresponding rows from the content and text tables.

Event Timeline

Change 506573 had a related patch set uploaded (by BPirkle; owner: BPirkle):
[mediawiki/extensions/DeletePagesForGood@master] Remove references to db fields rev_text_id and ar_text_id

https://gerrit.wikimedia.org/r/506573

Change 506573 abandoned by BPirkle:
Remove references to db fields rev_text_id and ar_text_id

Reason:
Extremely outdated

https://gerrit.wikimedia.org/r/506573

Change 958530 had a related patch set uploaded (by Seb35; author: BPirkle):

[mediawiki/extensions/DeletePagesForGood@master] Remove references to db fields rev_text_id and ar_text_id

https://gerrit.wikimedia.org/r/958530

Change 958530 merged by jenkins-bot:

[mediawiki/extensions/DeletePagesForGood@master] Remove references to db fields rev_text_id and ar_text_id

https://gerrit.wikimedia.org/r/958530

Seb35 assigned this task to BPirkle.
Seb35 added subscribers: BPirkle, Seb35.

Fixed by the patch 958530 of @BPirkle and myself.