The OS or browser versions seem like properties of the browser, and should therefore go into Browser.js, not downloadPageAction.js, where they currently reside.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T221022 [EPIC] Divide MobileFrontend component concerns | |||
| Declined | None | T220969 Move getAndroidVersion() and getChromeVersion() into Browser.js |
Event Timeline
Comment Actions
I think such a module should be moved into core or replaced with direct checks. Browser sniffing is usually a last resort and I'm curious if we actually need this library any more (maybe we should be removing it instead)
- A lot of the methods seem redundant now - supportsAnimations seems unnecessary given all Grade A browsers now support animations
A feature detection library in core might be an easier sell.