Page MenuHomePhabricator

Create new 'cancel' component
Closed, ResolvedPublic

Description

A/C
There should be a new Vue component
This should be used in the publish slot of the edit tools component
It should appear below the publish/save button
There should be an alt text/title which should use the message wikibase-cancel
It should be styled as according to the parent task
It should emit a 'cancel' event when clicked

Note:

  • This may be the point to consider re-use of existing button code (specifically, the translated alt-text, the background-svg and touch target size) e.g from EditPen, Publish
  • This task doesn't need any wiring to the store

Event Timeline

Tarrow created this task.Apr 15 2019, 1:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2019, 1:17 PM
Tarrow updated the task description. (Show Details)Apr 15 2019, 2:19 PM
Tarrow updated the task description. (Show Details)

Change 504282 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Introduce Cancel component with asset

https://gerrit.wikimedia.org/r/504282

Jakob_WMDE moved this task from Peer Review to Doing on the Wikidata-Termbox-Iteration-14 board.
Jakob_WMDE added a subscriber: Matthias_Geisler_WMDE.

Change 504282 merged by jenkins-bot:
[wikibase/termbox@master] Introduce Cancel component with asset

https://gerrit.wikimedia.org/r/504282

Change 505830 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Use v-slot instead of deprecated slot

https://gerrit.wikimedia.org/r/505830

Change 505830 merged by jenkins-bot:
[wikibase/termbox@master] Use v-slot instead of deprecated slot

https://gerrit.wikimedia.org/r/505830

Change 506196 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Introduce reusable button component

https://gerrit.wikimedia.org/r/506196

Change 506196 merged by jenkins-bot:
[wikibase/termbox@master] Introduce reusable button component

https://gerrit.wikimedia.org/r/506196