Page MenuHomePhabricator

Deprecate and remove ExtensionRegistry::load()
Open, Needs TriagePublic0 Story Points

Description

public function load( $path ) {
        $this->loadFromQueue(); // First clear the queue
        $this->queue( $path );
        $this->loadFromQueue();
}

This was very poorly thought out by me, and to the best of my knowledge, it's never been used. The main problem with this is that it breaks the dependency checking, since we have the expectation that everything is loaded at the same time. Should be safe to hard deprecate in 1.34 and then remove in 1.35.

Steps

  • Hard Deprecate in 1.34
  • Remove in 1.35

Event Timeline

Legoktm created this task.Apr 15 2019, 3:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2019, 3:09 PM

Change 504032 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] registration: Hard deprecated ExtensionRegistry::load()

https://gerrit.wikimedia.org/r/504032

After a little searching a little with code search, I believe the only place this is used is https://github.com/SemanticMediaWiki/SemanticGlossary/blob/master/SemanticGlossary.php#L25 .

D3r1ck01 claimed this task.Apr 19 2019, 5:51 PM
D3r1ck01 added a project: User-D3r1ck01.
D3r1ck01 moved this task from Backlog to Doing [WIP] on the User-D3r1ck01 board.

Change 504032 merged by jenkins-bot:
[mediawiki/core@master] registration: Deprecate ExtensionRegistry->load() in favor of ->queue()

https://gerrit.wikimedia.org/r/504032

D3r1ck01 removed D3r1ck01 as the assignee of this task.May 7 2019, 2:11 PM
D3r1ck01 updated the task description. (Show Details)
D3r1ck01 removed a project: Patch-For-Review.
D3r1ck01 moved this task from Doing [WIP] to Backlog on the User-D3r1ck01 board.
D3r1ck01 added a subscriber: D3r1ck01.

Removal is for 1.35.