Page MenuHomePhabricator

Deprecate and remove ExtensionRegistry::load()
Closed, ResolvedPublic0 Estimated Story Points

Description

public function load( $path ) {
        $this->loadFromQueue(); // First clear the queue
        $this->queue( $path );
        $this->loadFromQueue();
}

This was very poorly thought out by me, and to the best of my knowledge, it's never been used. The main problem with this is that it breaks the dependency checking, since we have the expectation that everything is loaded at the same time. Should be safe to hard deprecate in 1.34 and then remove in 1.35.

Steps

  • Hard Deprecate in 1.34
  • Remove in 1.35

Event Timeline

Change 504032 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] registration: Hard deprecated ExtensionRegistry::load()

https://gerrit.wikimedia.org/r/504032

xSavitar added a project: User-xSavitar.
xSavitar moved this task from Backlog to Doing [WIP] on the User-xSavitar board.

Change 504032 merged by jenkins-bot:
[mediawiki/core@master] registration: Deprecate ExtensionRegistry->load() in favor of ->queue()

https://gerrit.wikimedia.org/r/504032

xSavitar updated the task description. (Show Details)
xSavitar removed a project: Patch-For-Review.
xSavitar moved this task from Doing [WIP] to Backlog on the User-xSavitar board.
xSavitar subscribed.

@Jdforrester-WMF if I were to make a commit removing it now, would that just apply to 1.35 or is it best to wait a while before doing so? (Hope that makes sense.)

@Jdforrester-WMF if I were to make a commit removing it now, would that just apply to 1.35 or is it best to wait a while before doing so? (Hope that makes sense.)

Master is currently 1.34.0-alpha (see the file where that's set). When the 1.34 branch (REL1_34) is cut next week, then it'll be safe to do this (but it'd be better to wait a week or two just in case).

I will claim this as I do intend to work on it after the time frame mentioned by @Jdforrester-WMF .

Change 544305 had a related patch set uploaded (by TheSandDoctor; owner: TheSandDoctor):
[mediawiki/core@master] Removed ExtensionRegistry::load()

https://gerrit.wikimedia.org/r/544305

Change 544305 merged by jenkins-bot:
[mediawiki/core@master] registration: Remove ExtensionRegistry::load() method

https://gerrit.wikimedia.org/r/544305

TheSandDoctor moved this task from git review pending to merged/done on the User-TheSandDoctor board.

Merged now. Resolving.