Page MenuHomePhabricator

Make actions menu sticky
Closed, DeclinedPublic

Description

User story

As an advanced editor, I want easy access to the actions menu so that I can perform the actions I want (like editing or selecting the history of a page) without having to scroll all the way to the top of the page

Acceptance criteria

  • While in AMC mode, the actions menu will be sticky and appear upon scrolling up
  • All items on the actions menu and overflow menu will function as expected

Prototype

@alexhollender's prototype https://mobile-contributions.firebaseapp.com/nav4.html
@Jdrewniak's POC https://drive.google.com/file/d/11EoCJDBiyiqq-vO9-xOLm00b-0wTCziL/view

Dev notes

  • Test with CentralNotice and subtitles
  • {{{pageactionshtml}}} must be moved outside of pre-content heading-holder container in minerva.mustache.
  • Add the following CSS:
.minerva--amc-enabled .page-actions-menu {
	position: sticky;
	top: 0;
}

Event Timeline

ovasileva triaged this task as Medium priority.
ovasileva moved this task from Backlog to Stage 2 on the Advanced Mobile Contributions board.
ovasileva lowered the priority of this task from Medium to Low.Aug 28 2019, 3:13 PM

I think we can keep this as open and low, especially since navigation on mobile might become a priority again in the future and we'll have some experience with sticky elements. That said, I don't feel too strongly about this one. @alexhollender - any thoughts?

My preference would be close this as if priorities do ever change this ticket is likely to need a serious rewrite and Phabricator's search is good enough to find this given it's already tagged Advanced Mobile Contributions .

if we're going to work on making anything sticky on the mobile website I think we should prioritize sticky section headers, which would benefit significantly more people

Sounds good - closing this one then