Fatal error when submitting "insource" query on mediawiki.org
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Krinkle
	Apr 16 2019, 1:05 AM

Project Tags

Referenced Files

None

Subscribers

Description

Error

Request URL: https://www.mediawiki.org/w/index.php?search=insource%3A%2F%3Chr%2F&title=Special%3ASearch
Request ID:

message

Argument 1 passed to Elastica\Exception\ResponseException::__construct() must be an instance of Elastica\Request, null given

trace

Impact

Notes

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Pass connection to ElasticsearchIntermediary::succcess/failure	mediawiki/extensions/CirrusSearch	wmf/1.33.0-wmf.25	+35 -23
	Pass connection to ElasticsearchIntermediary::succcess/failure	mediawiki/extensions/CirrusSearch	master	+35 -23

Customize query in gerrit

Related Objects

Duplicates Merged Here: T221027: Terminating slash in insource regexp breaks PHP
T221042: Got "TypeError" when searching with prefix: in the Spanish Wikipedia
T220927: PHP fatal error in Elastica extension

Event Timeline

Krinkle created this task.Apr 16 2019, 1:05 AM

Restricted Application added a project: Discovery-Search. · View Herald TranscriptApr 16 2019, 1:05 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Looks like because insource uses a different connection than the standard connection (mitigation of cluster overloads over the weekend) the attempt to source the last sent request from the connection fails. Will need to get the right connection object into ElasticsearchIntermediary::multiFailure().

The higher level failure that was supposed to be reported was `invalid_regex_exception: expected '>' at position 3'

EBernhardson merged a task: T220927: PHP fatal error in Elastica extension.Apr 16 2019, 2:41 AM

EBernhardson merged a task: T221042: Got "TypeError" when searching with prefix: in the Spanish Wikipedia.

EBernhardson added a subscriber: Tufor.

EBernhardson added a subscriber: Amitie_10g.

Change 504231 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@master] Pass connection to ElasticsearchIntermediary::succcess/failure

https://gerrit.wikimedia.org/r/504231

gerritbot added a project: Patch-For-Review.Apr 16 2019, 2:44 AM

Change 504231 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Pass connection to ElasticsearchIntermediary::succcess/failure

https://gerrit.wikimedia.org/r/504231

Change 504371 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@wmf/1.33.0-wmf.25] Pass connection to ElasticsearchIntermediary::succcess/failure

https://gerrit.wikimedia.org/r/504371

EBernhardson merged a task: T221027: Terminating slash in insource regexp breaks PHP.Apr 16 2019, 11:22 PM

EBernhardson added a subscriber: PerfektesChaos.

Change 504371 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@wmf/1.33.0-wmf.25] Pass connection to ElasticsearchIntermediary::succcess/failure

https://gerrit.wikimedia.org/r/504371

EBernhardson claimed this task.Apr 16 2019, 11:35 PM

EBernhardson moved this task from needs triage to Current work on the Discovery-Search board.Apr 16 2019, 11:58 PM

EBernhardson edited projects, added: Discovery-Search (Current work); removed: Discovery-Search.

EBernhardson moved this task from Incoming to Needs Reporting on the Discovery-Search (Current work) board.

Krinkle moved this task from Untriaged to Aug2019/1.34.wmf.17+ on the Wikimedia-production-error board.Apr 16 2019, 11:59 PM

Krinkle removed a project: Patch-For-Review.Apr 19 2019, 5:41 PM

• debt closed this task as Resolved.Apr 19 2019, 9:02 PM

Krinkle moved this task from Aug2019/1.34.wmf.17+ to Resolved on the Wikimedia-production-error board.May 29 2019, 4:30 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM