Page MenuHomePhabricator

Move methods from Block to BlockManager
Open, MediumPublic5 Estimated Story Points


After the introduction of the BlockManager (T219441), move over methods on the Block class that belong there.

This includes helper methods for getting blocks that apply to a user, such as Block::chooseBlock.

It also includes methods that require knowledge of global configs, such as Block::appliesToUsertalk, which needs to know about $wgBlockAllowsUTEdit. This should be split between the BlockManager (to allow MultipleBlock (T206163) to handle the multiple block case). Other methods are similar to this.

This work will conflict with the Block refactor in T206163, and can be done afterwards.

Event Timeline

Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptApr 16 2019, 10:17 AM
Niharika set the point value for this task to 5.Apr 18 2019, 6:51 PM
Niharika triaged this task as Medium priority.Apr 24 2019, 6:32 PM
Tchanders moved this task from Ready to In Progress on the Anti-Harassment (Kaf - כ) board.

@Tchanders I don't have a good recollection of why I moved this ticket to In progress (maybe during a meeting discussion?). Do you think it's okay if we drop it from the board?