Page MenuHomePhabricator

Move methods from Block to BlockManager
Open, MediumPublic5 Estimated Story Points

Description

After the introduction of the BlockManager (T219441), move over methods on the Block class that belong there.

This includes helper methods for getting blocks that apply to a user, such as Block::chooseBlock.

It also includes methods that require knowledge of global configs, such as Block::appliesToUsertalk, which needs to know about $wgBlockAllowsUTEdit. This should be split between the BlockManager (to allow MultipleBlock (T206163) to handle the multiple block case). Other methods are similar to this.

This work will conflict with the Block refactor in T206163, and can be done afterwards.

Event Timeline

Niharika triaged this task as Medium priority.Apr 24 2019, 6:32 PM

@Tchanders I don't have a good recollection of why I moved this ticket to In progress (maybe during a meeting discussion?). Do you think it's okay if we drop it from the board?

Removing task assignee due to inactivity, as this open task has been assigned for more than two years (see emails sent to assignee on May26 and Jun17, and T270544). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be very welcome!

(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)