Page MenuHomePhabricator

puppet fact: migrate away from the uniqueid fact
Open, NormalPublic0 Story Points

Description

The unique id fact is no longer available in facter3. we have copied the fact to wmflib to support it for now. If we do really want to have a unique id the contents of /etc/machine-id is a better candidate then hostid which is used now.

The following files make reference to the uniqueid

  • modules/profile/manifests/backup/host.pp
    • this seems to be getting a radnom number between 1 and 7 for cron may be able to use cron_splay
  • modules/bacula/manifests/client.pp:
  • modules/bacula/manifests/director.pp:
  • modules/bacula/manifests/storage.pp:
    • theses are all password generaters could possibly use fqdn_rand_string
  • modules/puppetmaster/files/puppet-facts-export-puppetdb.py: yaml_data['uniqueid'] = '43434343'
  • modules/puppetmaster/files/puppet-facts-export-nodb.sh: sed -i -e 's@uniqueid:.*@uniqueid: "43434343"@' \ wmflib/lib
    • these are just sanitisation scripts and don't need to change

Event Timeline

jbond created this task.Apr 16 2019, 1:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 16 2019, 1:35 PM
colewhite triaged this task as Normal priority.Apr 16 2019, 3:36 PM
jbond updated the task description. (Show Details)Apr 16 2019, 7:02 PM
jbond updated the task description. (Show Details)