Page MenuHomePhabricator

Special:Block checkboxes should remember checked state
Open, NormalPublic3 Story Points

Description

Widgets on the Special:Block page should remember their default checked state, or if the user has interacted with them, the state that the user set.

Since T212391, checkboxes are enabled/disabled depending on the block parameters entered in the form (previously they were hidden/shown).

If a checkbox is disabled, it is also unchecked, to indicate that the option cannot be chosen for the particular block parameters entered. If the parameters change and it becomes checked again, it will still be unchecked. However, it should become checked again, if it was checked before.

It sends a misleading message that that option will be applied, e.g. that autoblocks would be applied for this block (and you can't prevent that from happening):

Event Timeline

Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptApr 16 2019, 5:29 PM

Why can't they be checked in their disabled state?

I think it sends a misleading message that that option will be applied, e.g. that autoblocks would be applied for this block (and you can't prevent that from happening):

Niharika triaged this task as Normal priority.
Niharika added a subscriber: Niharika.

I think it sends a misleading message that that option will be applied, e.g. that autoblocks would be applied for this block (and you can't prevent that from happening):

Completely agree.

Good catch, @Tchanders. We should fix this.

Niharika updated the task description. (Show Details)Apr 18 2019, 6:29 PM
Niharika set the point value for this task to 3.Apr 18 2019, 6:42 PM