Page MenuHomePhabricator
Create Task
Maniphest T221149

Modify "SiteImporter.php" and "SiteExporter.php" to handle "LanguageCode" as well
Open, Needs TriagePublic
Actions

Description

The script importSites.php is used to import a list of XML formatted sites list as explained here https://www.mediawiki.org/wiki/Manual:Sites_table#Managing_the_sites_table
For some reason this script ignores the LanguageCode parameter that should instead fill the site_language in the table.
To your knowledge is there a specific reason for this function being excluded from the code?
If no such reason exist, I would propose to add this functionality.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Modify "SiteExporter.php" and "SiteImporter.php" to handle "LanguageCode" property as wellmediawiki/coremaster+112 -26
Modify "SiteExporter.php" and "SiteImporter.php" to handle "LanguageCode" property as wellmediawiki/coremaster+82 -6
Modify "SiteExporter.php" and "SiteImporter.php" to handle "LanguageCode" property as wellmediawiki/coremaster+80 -5
Modify "SiteExporter.php" and "SiteImporter.php" to handle "LanguageCode" property as wellmediawiki/coremaster+79 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

lucamauri created this task.Apr 16 2019, 9:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 16 2019, 9:43 PM
lucamauri claimed this task.Apr 16 2019, 9:45 PM

The modification only takes few lines of code in a couple of files. I tested this on my local MediaWiki test installation and, if there is no specific reason not to have this function, I would commit it myself.

lucamauri added a project: MediaWiki-Site-system.Apr 23 2019, 4:26 PM
gerritbot added a comment.May 2 2019, 4:03 PM

Change 507821 had a related patch set uploaded (by Luca Mauri; owner: Luca Mauri):
[mediawiki/core@master] Modify "importSites.php" to import "LanguageCode" as well

https://gerrit.wikimedia.org/r/507821

gerritbot added a project: Patch-For-Review.May 2 2019, 4:03 PM
lucamauri renamed this task from Modify "importSites.php" to import "LanguageCode" as well to Modify "SiteImporter.php" and "SiteExporter.php" to handle "LanguageCode" as well.May 4 2019, 6:46 PM
Reedy removed a subtask: T222516: Adapt http://www.mediawiki.org/xml/sitelist-1.0/ for the new XSD file.May 4 2019, 10:18 PM
Reedy added a parent task: T222516: Adapt http://www.mediawiki.org/xml/sitelist-1.0/ for the new XSD file.
Reedy mentioned this in T222516: Adapt http://www.mediawiki.org/xml/sitelist-1.0/ for the new XSD file.May 5 2019, 8:58 PM
Krinkle moved this task from Untriaged to Usage problem on the MediaWiki-libs-Rdbms board.Jun 27 2019, 9:07 PM
Krinkle removed a project: MediaWiki-libs-Rdbms.Jul 18 2019, 7:55 PM
gerritbot added a comment.Apr 26 2020, 4:34 PM

Change 592489 had a related patch set uploaded (by Luca Mauri; owner: Luca Mauri):
[mediawiki/core@master] Modify "SiteExporter.php" and "SiteImporter.php" to handle "LanguageCode" property as well

https://gerrit.wikimedia.org/r/592489

gerritbot added a comment.Apr 26 2020, 4:48 PM

Change 507821 abandoned by Luca Mauri:
Modify "SiteExporter.php" and "SiteImporter.php" to handle "LanguageCode" property as well

Reason:
Replaced by https://gerrit.wikimedia.org/r/#/c/mediawiki/core/ /592489/

https://gerrit.wikimedia.org/r/507821

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.May 25 2021, 8:56 PM
gerritbot added a comment.May 30 2021, 3:23 PM

Change 697108 had a related patch set uploaded (by Luca Mauri; author: Luca Mauri):

[mediawiki/core@master] Modify "SiteExporter.php" and "SiteImporter.php" to handle "LanguageCode" property as well

https://gerrit.wikimedia.org/r/697108

gerritbot added a project: Patch-For-Review.May 30 2021, 3:23 PM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptMay 30 2021, 3:23 PM
gerritbot added a comment.May 30 2021, 3:35 PM

Change 592489 abandoned by Luca Mauri:

[mediawiki/core@master] Modify "SiteExporter.php" and "SiteImporter.php" to handle "LanguageCode" property as well

Reason:

Replaced by https://gerrit.wikimedia.org/r/c/mediawiki/core/ /697108

https://gerrit.wikimedia.org/r/592489

Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 1 2023, 8:29 PM
gerritbot added a comment.May 7 2023, 5:12 PM

Change 915723 had a related patch set uploaded (by Luca Mauri; author: Luca Mauri):

[mediawiki/core@master] Modify "SiteExporter.php" and "SiteImporter.php" to handle "LanguageCode" property as well

https://gerrit.wikimedia.org/r/915723

gerritbot added a project: Patch-For-Review.May 7 2023, 5:12 PM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptMay 7 2023, 5:12 PM
gerritbot added a comment.May 7 2023, 5:22 PM

Change 697108 abandoned by Luca Mauri:

[mediawiki/core@master] Modify "SiteExporter.php" and "SiteImporter.php" to handle "LanguageCode" property as well

Reason:

Replaced by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/915723

https://gerrit.wikimedia.org/r/697108

Lens0021 subscribed.Aug 15 2023, 7:41 AM
Lens0021 mentioned this in T344246: Wikibase\Lib\LanguageNameLookup::getName(): Argument #1 () must be of type string, null given.Aug 15 2023, 12:55 PM
Winston_Sung moved this task from Backlog to General on the MediaWiki-Site-system board.Feb 2 2024, 4:33 PM
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 12 2024, 11:13 AM
Aklapper removed lucamauri as the assignee of this task.May 16 2024, 5:03 PM

@lucamauri: Removing task assignee as this open task has been assigned for more than two years - see the email sent to all task assignees on 2024-04-15.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

lucamauri claimed this task.May 11 2025, 7:10 PM

@Aklapper actually my work on the task was done, I was simply waiting for someone to accept my patch.
Nevertheless, I have rebased the patch and submitted again, hoping for someone to review an accept it.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits