Page MenuHomePhabricator
Create Task
Maniphest T221165

Remove usage of deprecated cache code
Closed, ResolvedPublic
Actions

Description

Examples:

  • wfMemcKey()
  • wfGlobalCacheKey()
  • ObjectCache::getMainStashInstance()

Details

SubjectRepoBranchLines +/-
Remove usage of deprecated cache code from Echomediawiki/extensions/Echomaster+11 -5
Customize query in gerrit

Related Objects

Mentioned In
W2269 Echo Tasks

Event Timeline

kostajh created this task.Apr 17 2019, 12:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2019, 12:06 AM
gerritbot added a comment.Apr 17 2019, 12:00 PM

Change 504536 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/extensions/Echo@master] Remove usage of deprecated cache code from Echo

https://gerrit.wikimedia.org/r/504536

gerritbot added a project: Patch-For-Review.Apr 17 2019, 12:00 PM
xSavitar added a project: User-xSavitar.Apr 17 2019, 12:04 PM
xSavitar moved this task from Backlog to Under Review on the User-xSavitar board.
xSavitar moved this task from Under Review to Doing [WIP] on the User-xSavitar board.Apr 17 2019, 12:35 PM
SBisson mentioned this in W2269 Echo Tasks.Apr 17 2019, 3:00 PM
xSavitar moved this task from Doing [WIP] to Projects [Watch] on the User-xSavitar board.Apr 17 2019, 3:51 PM
xSavitar moved this task from Projects [Watch] to Under Review on the User-xSavitar board.
xSavitar claimed this task.Apr 17 2019, 4:14 PM
gerritbot added a comment.Apr 17 2019, 6:16 PM

Change 504536 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Remove usage of deprecated cache code from Echo

https://gerrit.wikimedia.org/r/504536

xSavitar moved this task from Under Review to Reviewed/Resolved on the User-xSavitar board.Apr 17 2019, 6:17 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 17 2019, 7:00 PM
xSavitar closed this task as Resolved.Apr 18 2019, 12:27 AM
xSavitar triaged this task as Medium priority.
xSavitar removed a project: Patch-For-Review.
SBisson subscribed.Apr 18 2019, 4:58 AM

@D3r1ck01 FYI, we generally don't close tasks we fix ourselves. We try to get someone else to independently verify that it's OK. This is fairly technical so I wouldn't sent it to our QA for closing but maybe @kostajh could re-run his code analysis to confirm that all deprecation warnings related to "caching" are solved.

xSavitar reopened this task as Open.Apr 18 2019, 9:49 AM
xSavitar removed xSavitar as the assignee of this task.
xSavitar subscribed.

Oh @SBisson, sorry about that. Reopening for further checks to be done before resolving, I'm really sorry!

SBisson assigned this task to xSavitar.Apr 19 2019, 1:52 PM
SBisson edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

Hey, I didn't mean to complain or sound strict about it. It's not a hard rule but just our the Growth team usually operates.

SBisson moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 19 2019, 1:52 PM
xSavitar added a comment.Apr 19 2019, 1:58 PM

Sure, and I wish to respect that :) thanks!

kostajh closed this task as Resolved.Apr 22 2019, 5:51 PM

All looks good. Thanks for your work on this @D3r1ck01, much appreciated!

xSavitar awarded a token.Apr 22 2019, 5:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits