Page MenuHomePhabricator

ContentTranslation\Test\AbuseFilterCheck\AbuseFilterCheckTest test failures
Closed, ResolvedPublic

Description

14:21:39 Time: 4.32 minutes, Memory: 745.19MB
14:21:39 
14:21:39 There were 8 failures:
14:21:39 
14:21:39 1) ContentTranslation\Test\AbuseFilterCheck\AbuseFilterCheckTest::testCheckTitle with data set "Disallow" ('page_title === "ContentTransl... test"', array(array('abusefilter-disallow')), array(array(array('disallow', array('abusefilter-disallow')))))
14:21:39 Failed asserting that two arrays are equal.
14:21:39 --- Expected
14:21:39 +++ Actual
14:21:39 @@ @@
14:21:39  Array (
14:21:39 -    0 => Array (...)
14:21:39  )
14:21:39 
14:21:39 /workspace/src/tests/phpunit/MediaWikiTestCase.php:2097
14:21:39 /workspace/src/extensions/ContentTranslation/tests/phpunit/AbuseFilterCheckTest.php:96
14:21:39 /workspace/src/tests/phpunit/MediaWikiTestCase.php:427
14:21:39 /workspace/src/maintenance/doMaintenance.php:96
14:21:39 
14:21:39 2) ContentTranslation\Test\AbuseFilterCheck\AbuseFilterCheckTest::testCheckTitle with data set "Warning" ('user_name === "ContentTranslator"', array(array('abusefilter-warning-cx')), array(array(array('warn', array('abusefilter-warning-cx'), '⧼abusefilter-warning-cx⧽'))))
14:21:39 Failed asserting that two arrays are equal.
14:21:39 --- Expected
14:21:39 +++ Actual
14:21:39 @@ @@
14:21:39  Array (
14:21:39 -    0 => Array (...)
14:21:39  )
14:21:39 
14:21:39 /workspace/src/tests/phpunit/MediaWikiTestCase.php:2097
14:21:39 /workspace/src/extensions/ContentTranslation/tests/phpunit/AbuseFilterCheckTest.php:96
14:21:39 /workspace/src/tests/phpunit/MediaWikiTestCase.php:427
14:21:39 /workspace/src/maintenance/doMaintenance.php:96

See https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-hhvm-docker/13405/console for more, and it's consistently failing on patches.

Patches affected

Event Timeline

D3r1ck01 created this task.Apr 17 2019, 1:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2019, 1:25 PM
D3r1ck01 updated the task description. (Show Details)Apr 17 2019, 1:27 PM
Krinkle triaged this task as Unbreak Now! priority.Apr 17 2019, 1:28 PM
Restricted Application added subscribers: Daimona, Liuxinyu970226, TerraCodes. · View Herald TranscriptApr 17 2019, 1:28 PM
D3r1ck01 updated the task description. (Show Details)Apr 17 2019, 1:29 PM

Causing VE commits to fail as well.

Change 504548 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/ContentTranslation@master] Revert "Change parameters order for AbuseFilter"

https://gerrit.wikimedia.org/r/504548

Change 504548 merged by Krinkle:
[mediawiki/extensions/ContentTranslation@master] Revert "Change parameters order for AbuseFilter"

https://gerrit.wikimedia.org/r/504548

D3r1ck01 updated the task description. (Show Details)Apr 17 2019, 1:48 PM
Daimona closed this task as Resolved.Apr 17 2019, 2:01 PM
Daimona assigned this task to Krinkle.
Daimona removed a project: Patch-For-Review.

Yes, the CX patch was merged to soon, since as stated in commit message it was waiting for the parent. Thanks Krinkle for acting fast, I'm sorry but I'm a bit absent these days.