Page MenuHomePhabricator

[Regression wmf.1] Table selection not active after row/column operation
Closed, ResolvedPublic

Description

Steps to replicate:

  1. Select a cell on a table.
  2. Do a row/column operation, such as "Insert Before"/"Move After" etc.

The highlight color of the cell selection and the operator arrow gets greyed out.

Screen Shot 2019-04-17 at 3.07.21 PM.png (306×455 px, 25 KB)

Event Timeline

Esanders renamed this task from [Regression wmf.1] The highlight color of row/column operator and the selection gets greyed out after making a change on a table cell to [Regression wmf.1] Table selection not active after row/column operation.Apr 22 2019, 12:11 PM

Change 505631 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] (De)activate table selection on context menu toggle

https://gerrit.wikimedia.org/r/505631

Change 505631 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] (De)activate table selection on context menu toggle

https://gerrit.wikimedia.org/r/505631

Change 506223 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d0ff41a71)

https://gerrit.wikimedia.org/r/506223

Change 506224 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b049d6049)

https://gerrit.wikimedia.org/r/506224

Change 506223 abandoned by Jforrester:
Update VE core submodule to master (d0ff41a71)

https://gerrit.wikimedia.org/r/506223

Change 506224 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b049d6049)

https://gerrit.wikimedia.org/r/506224

@Esanders: Found a new regression today on table cell selection while testing this: T221901

JTannerWMF subscribed.

Putting this task back in code review due to the regression @Ryasmeen found

@JTannerWMF: Nope, this is fine being on "Product own review", the regression was fixed a month ago. We were just talking about this retrospectively.