Page MenuHomePhabricator
Create Task
Maniphest T221336

Undefined index: pages in Api.php
Closed, ResolvedPublic
Actions

Description

Another error in the application that we need to clean up.

2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP Notice:  Undefined index: pages in /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/utils/Api.php on line 175
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP Stack trace:
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP   1. {main}() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/http/book.php:0
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP   2. BookCreator->create() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/http/book.php:38
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP   3. BookProvider->get() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/book/BookCreator.php:32
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP   4. BookProvider->getMetadata() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/book/BookProvider.php:40
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP   5. BookProvider->getPages() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/book/BookProvider.php:117
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP   6. GuzzleHttp\Promise\Promise->wait() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/book/BookProvider.php:196
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP   7. GuzzleHttp\Promise\Promise->waitIfPending() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/promises/src/Promise.php:62
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP   8. GuzzleHttp\Promise\Promise->invokeWaitList() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/promises/src/Promise.php:225
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP   9. GuzzleHttp\Promise\Promise->waitIfPending() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/promises/src/Promise.php:267
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP  10. GuzzleHttp\Promise\Promise->invokeWaitFn() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/promises/src/Promise.php:223
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP  11. GuzzleHttp\Handler\CurlMultiHandler->execute() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/promises/src/Promise.php:246
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP  12. GuzzleHttp\Handler\CurlMultiHandler->tick() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/guzzle/src/Handler/CurlMultiHandler.php:125
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP  13. GuzzleHttp\Promise\TaskQueue->run() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/guzzle/src/Handler/CurlMultiHandler.php:98
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP  14. GuzzleHttp\Promise\Promise::GuzzleHttp\Promise\{closure}() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/promises/src/TaskQueue.php:47
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP  15. GuzzleHttp\Promise\Promise::callHandler() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/promises/src/Promise.php:156
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP  16. Api->{closure:/mnt/nfs/labstore-secondary-tools-project/wsexport/tool/utils/Api.php:169-171}() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/promises/src/Promise.php:203
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP  17. Api->parseGetPageResponse() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/utils/Api.php:170
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP Warning:  Invalid argument supplied for foreach() in /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/utils/Api.php on line 175
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP Stack trace:
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP   1. {main}() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/http/book.php:0
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP   2. BookCreator->create() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/http/book.php:38
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP   3. BookProvider->get() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/book/BookCreator.php:32
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP   4. BookProvider->getMetadata() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/book/BookProvider.php:40
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP   5. BookProvider->getPages() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/book/BookProvider.php:117
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP   6. GuzzleHttp\Promise\Promise->wait() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/book/BookProvider.php:196
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP   7. GuzzleHttp\Promise\Promise->waitIfPending() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/promises/src/Promise.php:62
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP   8. GuzzleHttp\Promise\Promise->invokeWaitList() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/promises/src/Promise.php:225
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP   9. GuzzleHttp\Promise\Promise->waitIfPending() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/promises/src/Promise.php:267
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP  10. GuzzleHttp\Promise\Promise->invokeWaitFn() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/promises/src/Promise.php:223
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP  11. GuzzleHttp\Handler\CurlMultiHandler->execute() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/promises/src/Promise.php:246
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP  12. GuzzleHttp\Handler\CurlMultiHandler->tick() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/guzzle/src/Handler/CurlMultiHandler.php:125
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP  13. GuzzleHttp\Promise\TaskQueue->run() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/guzzle/src/Handler/CurlMultiHandler.php:98
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP  14. GuzzleHttp\Promise\Promise::GuzzleHttp\Promise\{closure}() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/promises/src/TaskQueue.php:47
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP  15. GuzzleHttp\Promise\Promise::callHandler() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/promises/src/Promise.php:156
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP  16. Api->{closure:/mnt/nfs/labstore-secondary-tools-project/wsexport/tool/utils/Api.php:169-171}() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/vendor/guzzlehttp/promises/src/Promise.php:203
2019-04-14 21:07:15: (mod_fastcgi.c.2543) FastCGI-stderr: PHP  17. Api->parseGetPageResponse() /mnt/nfs/labstore-secondary-tools-project/wsexport/tool/utils/Api.php:170

Event Timeline

MaxSem created this task.Apr 18 2019, 1:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2019, 1:31 AM
• aezell updated the task description. (Show Details)Apr 19 2019, 3:39 PM
MaxSem added a project: Community-Tech-Sprint.Apr 23 2019, 7:39 PM
MaxSem moved this task from Backlog to In sprint on the WS Export board.
MaxSem claimed this task.Apr 24 2019, 2:55 AM
MaxSem moved this task from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.

Ready for review: https://github.com/wsexport/tool/pull/161

Mooeypoo moved this task from Needs Review/Feedback to QA on the Community-Tech-Sprint board.May 2 2019, 11:09 PM
dom_walden moved this task from QA to Product sign-off on the Community-Tech-Sprint board.May 4 2019, 12:29 PM
dom_walden subscribed.

Looking at the error and access logs on wsexport prod, I found a way to reproduce on production by navigating to: https://tools.wmflabs.org/wsexport-test/book.php?lang=ru&page=%D0%90%D0%BB%D0%B5%D0%BA%D1%81%D0%B0%D0%BD%D0%B4%D1%80_%D0%A1%D0%B5%D1%80%D0%B3%D0%B5%D0%B5%D0%B2%D0%B8%D1%87_%D0%9F%D1%83%D1%88%D0%BA%D0%B8%D0%BD&format=epub-3&fonts=freeserif

I did this on wsexport-test and I don't see an error in the logs.

• Niharika moved this task from New & TBD Tickets to In Sprint 🏃‍♀️🏃‍♂️ on the Community-Tech board.May 6 2019, 3:44 PM
• jmatazzoni closed this task as Resolved.May 6 2019, 10:41 PM
• jmatazzoni moved this task from Product sign-off to Done on the Community-Tech-Sprint board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL