MassMessage not delivering
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	• Elitre
	Apr 18 2019, 12:54 PM

Description

It looks like MassMessage hasn't delivered any of the messages sent today.
https://meta.wikimedia.org/wiki/Special:Log/massmessage doesn't show errors and queue seems empty, but nothing went through.

I am willing to send my 150 messages manually if I have to, but people would hate me when the thing starts working again and they receive a duplicate :/

Details

	Subject	Repo	Branch	Lines +/-
	Revert "jobqueue: add GenericParameterJob and RunnableJob interface"	mediawiki/core	master	+180 -362
	Revert "jobqueue: add GenericParameterJob and RunnableJob interface"	mediawiki/core	wmf/1.34.0-wmf.1	+180 -362

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	• mmodell	T220726 1.34.0-wmf.1 deployment blockers
		Duplicate		None	T221365 MassMessage not delivering

Event Timeline

• Elitre created this task.Apr 18 2019, 12:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2019, 12:54 PM

• Elitre triaged this task as Unbreak Now! priority.Apr 18 2019, 12:54 PM

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptApr 18 2019, 12:54 PM

(setting prio per IRC chat)

• Elitre added a project: MassMessage.Apr 18 2019, 12:55 PM

Volans added a parent task: T220726: 1.34.0-wmf.1 deployment blockers.Apr 18 2019, 12:56 PM

Joe mentioned this in T221368: cdnPurge and other jobs fail completely to execute.Apr 18 2019, 12:56 PM

Testing now...

This one went through: https://sv.wikipedia.org/wiki/Användardiskussion:Johan_(WMF)#Test_for_https://phabricator.wikimedia.org/T221365

@Elitre the problem seems to be a regression in MediaWiki, tracked at T221368. @Reedy reverted the group 1 wikis (including meta) to the previous version and now the messages can be re-sent. I don't think there should be duplicates, you can quote me on that and blame me for the annoyance :)

In T221365#5122559, @Joe wrote:

@Elitre the problem seems to be a regression in MediaWiki, tracked at T221368. @Reedy reverted the group 1 wikis (including meta) to the previous version and now the messages can be re-sent. I don't think there should be duplicates, you can quote me on that and blame me for the annoyance :)

Thanks. I am going into meetings and may not be able to re-attempt for a bit, but when I do I'll LYK the outcome.
I am very nervous about bothering many people with a potential duplicate, but thank you everyone for your help here <3

Actually, tried again and it seems to have worked (example).

Change 504884 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Revert "jobqueue: add GenericParameterJob and RunnableJob interface"

https://gerrit.wikimedia.org/r/504884

Change 504885 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@wmf/1.34.0-wmf.1] Revert "jobqueue: add GenericParameterJob and RunnableJob interface"

https://gerrit.wikimedia.org/r/504885

Reedy closed this task as a duplicate of T221368: cdnPurge and other jobs fail completely to execute.Apr 18 2019, 2:33 PM

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptApr 18 2019, 2:33 PM

Change 504885 abandoned by Jforrester:
Revert "jobqueue: add GenericParameterJob and RunnableJob interface"

Reason:
Fingers crossed, we don't need this.

https://gerrit.wikimedia.org/r/504885

Change 504884 abandoned by Jforrester:
Revert "jobqueue: add GenericParameterJob and RunnableJob interface"

Reason:
Fingers crossed, we don't need this.

https://gerrit.wikimedia.org/r/504884