Maniphest T221383

SpecialBlock should not be aware of the container
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	dbarratt
	Apr 18 2019, 3:54 PM

Tags

Referenced Files

None

Subscribers

Description

Problem
In T219684 dependencies were added to SpecialBlock and the class became aware of the container.

Solution
SpecialBlock should have its dependencies injected into it (see T222388).

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Duplicate		None	T221383 SpecialBlock should not be aware of the container
		Resolved		dmaza	T219684 BlockRestriction should be a service instead of a singleton
		Resolved		Mainframe98	T222388 Create a mechanism for SpecialPages and API modules to have dependencies injected into them

Event Timeline

dbarratt created this task.Apr 18 2019, 3:54 PM

Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptApr 18 2019, 3:54 PM

dbarratt added a subtask: T219684: BlockRestriction should be a service instead of a singleton.Apr 18 2019, 3:54 PM

Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment-Team board.Apr 18 2019, 5:30 PM

dbarratt added a project: Technical-Debt.Apr 23 2019, 5:40 PM

dmaza closed subtask T219684: BlockRestriction should be a service instead of a singleton as Resolved.Apr 29 2019, 2:57 PM

dbarratt added a subtask: T222388: Create a mechanism for SpecialPages and API modules to have dependencies injected into them.May 2 2019, 6:26 PM

dbarratt removed a project: Anti-Harassment-Team.May 7 2019, 9:50 PM

Tchanders moved this task from Backlog to User blocking on the MediaWiki-User-management board.Jun 5 2019, 8:54 PM

SpecialBlock shouldn't become a service; instead, SpecialPageFactory should be a service which instantiates SpecialBlock. See T222388.

Anomie closed subtask T222388: Create a mechanism for SpecialPages and API modules to have dependencies injected into them as Resolved.Sep 9 2019, 7:41 PM

Mainframe98 mentioned this in T232506: Inject services into special pages.Sep 10 2019, 5:11 PM

DannyS712 added a project: Dependency injection.Mar 20 2020, 5:16 PM

dbarratt updated the task description. (Show Details)Apr 20 2020, 3:26 PM

DannyS712 edited projects, added MediaWiki-Blocks; removed MediaWiki-User-management.Apr 25 2020, 12:10 AM

Restricted Application added a project: MediaWiki-User-management. · View Herald TranscriptApr 25 2020, 12:10 AM

Aklapper removed a project: MediaWiki-User-management.Apr 25 2020, 12:23 PM

dbarratt closed this task as a duplicate of T252253: Inject services to SpecialBlock rather than summon them through MediaWikiServices class.May 11 2020, 3:58 PM