Page MenuHomePhabricator

Make sure any monolog + eventbus fields with binary data are base64 encoded
Closed, ResolvedPublic

Description

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2019.04.18/mediawiki?id=AWoxNOqbm4XPTDeIOt1z&_g=()

Malformed UTF-8 characters, possibly incorrectly encoded

These are likely coming from incorrectly encoded binary params. We want to pass all event fields given to EventBus via the EventBusMonologHandler through EventBus::replaceBinaryValues.

Event Timeline

Ottomata created this task.Apr 18 2019, 4:21 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptApr 18 2019, 4:21 PM

Change 504945 had a related patch set uploaded (by Ottomata; owner: Ottomata):
[mediawiki/extensions/EventBus@master] Replace binary strings in monolog generated events

https://gerrit.wikimedia.org/r/504945

@bd808 this means that e.g. params with binary string values will end up looking like this:

"data:application/octet-stream;base64,XXXXBASE64STRINGHEREXXXX"

Hope that is ok!

Change 504945 merged by Ottomata:
[mediawiki/extensions/EventBus@master] Replace binary strings in monolog generated events

https://gerrit.wikimedia.org/r/504945

Change 504986 had a related patch set uploaded (by Mobrovac; owner: Ottomata):
[mediawiki/extensions/EventBus@wmf/1.34.0-wmf.1] Replace binary strings in monolog generated events

https://gerrit.wikimedia.org/r/504986

Change 504986 merged by Mobrovac:
[mediawiki/extensions/EventBus@wmf/1.34.0-wmf.1] Replace binary strings in monolog generated events

https://gerrit.wikimedia.org/r/504986

mobrovac closed this task as Resolved.Apr 18 2019, 11:17 PM
mobrovac triaged this task as High priority.
mobrovac removed a project: Patch-For-Review.

Fix deployed, all looking good.