Page MenuHomePhabricator

Show block notice in mobile VE
Closed, DuplicatePublic

Description

If you edit an article from a blocked IP address in mobile VE, it provides no warning that you are blocked from editing. Instead it let's you perform the edit but then prevents you from saving the edit once you are done. In many cases, this will cause the loss of edits, especially for editors who have simply forgotten to log in and are included in an IP rangeblock (which is common).

Event Timeline

Thank you for raising, @kaldari. Being led to believe you're able to edit when you are in fact not able to and not being given feedback as to why is frustrating.

I believe the issue you've encountered today is represented in T167078@matmarex, can you confirm this issue, T221400, and T167078 are one and the same?

What is being done about this?

Assuming T221400 and T167078 are connected, we will be resolving them as part of our work this quarter to experiment with VE being the default mobile editing interface on a select number of wikis. See: T221190

cc @Esanders @DLynch


Edit: striking through the need for @matmarex's input on the question above

@ppelberg - No, this is a separate bug from T167078 (although that was a good guess). VE specifically told me that I was blocked after trying to save my edit (rather than saying "Error: Edit not saved"), and I wasn't trying to add anything from the spam blacklist.

I think this might be a child (or duplicate) of T221190 though.

No,VE specifically told me that I was blocked after trying to save my edit (rather than saying "Error: Edit not saved"), and I wasn't trying to add anything from the spam blacklist.

Ah, okay. Noted.

I think this might be a child (or duplicate) of T221190 though.

Going off @Esanders adding T221190 as a parent to this task, and the guidance @matmarex shared with me in chat, it seems you nailed this one. Thank you, @kaldari.

JTannerWMF added a subscriber: JTannerWMF.

When should this happen relative to our other work @Esanders

Esanders renamed this task from Mobile VisualEditor provides no warning of blocked status to Show block notice in mobile VE.Apr 25 2019, 2:31 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.

Change 506467 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] Show block notice in VE

https://gerrit.wikimedia.org/r/506467

Esanders added a subscriber: Tchanders.

Acutally @Tchanders beat us to this by 5 months! Merging into the original task.