Page MenuHomePhabricator

Non-white reading themes do not preserve legend colors
Closed, ResolvedPublicBUG REPORT

Description

How many times were you able to reproduce it?

Every time

Steps to reproduce

  1. Go to "List of career achievements by Tiger Woods" article
  2. Go to "Results timeline" area under "Major championships"
  3. In white theme, note the green, yellow and gray colored table cells
  4. Switch to a different reading theme - green, yellow and gray coloring disappears.

Expected results

Legend coloring should stay green, yellow and gray when switching themes.

Actual results

Coloring disappears

Screenshots

IMG_2922.PNG (2×1 px, 405 KB)

IMG_2923.PNG (2×1 px, 1 MB)

Environments observed

App version: 6.2.1
OS versions: iOS 12.1.4
Device model: iPhone X
Device language: EN

Affected articles?

All

Event Timeline

LGoto triaged this task as Low priority.Apr 23 2019, 8:23 PM
LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
LGoto added a subscriber: LGoto.

Per grooming, limit the application of themes to some templates.

JMinor added subscribers: Mhurd, JMinor.

Per @Mhurd comment, the template info is not included in the markup, so the approach of excluding templates won't work. We'll need to look a the markup.

The page library has a theme "demo" which is useful to see if theme changes introduce regressions. It presents 50 or so articles which were difficult to theme - you can pick a theme then scroll through all the articles (they're in iframes on one giant page for easy proofing) and look for unexpected side-effects. (especially useful when choosing black theme - when you scroll it's easy to see if your change broke anything because you'll see bright spots). Oh, and definitely add to the ~50 articles any article exhibiting the bug you're fixing. Ping me if you want a quick walk-through.

FWIW, template info is included in Parsoid output. So, once iOS moves to /page/mobile-html this could be theoretically possible.

Having said that this seems similar enough to what was fixed in https://github.com/wikimedia/wikimedia-page-library/pull/211. We would just have to also include <td>s to the selector in addition of 'span[style*="background"]' or make this work for all element types, e.g. '*[style*="background"]'