Actually (hard) deprecate SearchEngine::transformSearchTerm and remove
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

Follow-up to T198318 where it was soft-deprecated.

Steps

Hard deprecate in 1.34
Remove in 1.35

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+2 -2	SearchEngine: Followup on I623b39e7ec791a66c4cf40
	mediawiki/core	master	+1 -14	SearchEngine: Hard deprecate SearchEngine::transformSearchTerm()

Customize query in gerrit

Related Objects

Mentioned Here: T220656: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.34 release
T198318: Change how SpecialSearch/SearchEngine handles the 'prefix' URI param set by the InputBox extension

Event Timeline

Jdforrester-WMF triaged this task as Lowest priority.Apr 19 2019, 12:13 AM

Jdforrester-WMF created this task.

Restricted Application added a project: Discovery-Search. · View Herald TranscriptApr 19 2019, 12:13 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 505269 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] SearchEngine: Hard deprecate SearchEngine::transformSearchTerm()

https://gerrit.wikimedia.org/r/505269

gerritbot added a project: Patch-For-Review.Apr 19 2019, 5:44 PM

@Jdforrester-WMF, hard deprecation patch up! Can still stop a few places where this is used: https://codesearch.wmflabs.org/search/?q=(%3A%3A%7C-%3E)transformSearchTerm&i=nope&files=&repos=, once they're cleaned up, removal is safe! Thanks

D3r1ck01 claimed this task.Apr 19 2019, 5:45 PM

D3r1ck01 added a project: User-D3r1ck01.

D3r1ck01 moved this task from Backlog to Doing [WIP] on the User-D3r1ck01 board.

D3r1ck01 moved this task from Doing [WIP] to Under Review on the User-D3r1ck01 board.Apr 20 2019, 11:05 PM

debt moved this task from needs triage to making others happy on the Discovery-Search board.May 2 2019, 5:16 PM

Change 505269 merged by jenkins-bot:
[mediawiki/core@master] SearchEngine: Hard deprecate SearchEngine::transformSearchTerm()

https://gerrit.wikimedia.org/r/505269

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.5; 2019-05-14).May 7 2019, 8:00 PM

Thank you!

This is now stalled until 1.34.x is cut and so we can land this in MW 1.35.

Krinkle removed a project: MW-1.34-notes (1.34.0-wmf.5; 2019-05-14).May 7 2019, 8:05 PM

You're welcome @Jdforrester-WMF, I've removed self as assignee for now but will keep monitoring. I've also updated the task description a little.

D3r1ck01 moved this task from Under Review to Backlog on the User-D3r1ck01 board.May 7 2019, 8:12 PM

Change 509068 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] SearchEngine: Followup on I623b39e7ec791a66c4cf40

https://gerrit.wikimedia.org/r/509068

gerritbot added a project: Patch-For-Review.May 9 2019, 2:43 PM

Change 509068 merged by jenkins-bot:
[mediawiki/core@master] SearchEngine: Followup on I623b39e7ec791a66c4cf40

https://gerrit.wikimedia.org/r/509068

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.5; 2019-05-14).May 9 2019, 4:00 PM

D3r1ck01 removed a project: Patch-For-Review.May 9 2019, 9:47 PM

D3r1ck01 removed a project: User-D3r1ck01.May 18 2019, 3:00 PM

Krinkle moved this task from Untriaged to 2020 | MW 1.35 / 1.36 on the Technical-Debt (Deprecation process) board.May 22 2019, 7:06 PM

Krinkle moved this task from 2020 | MW 1.35 / 1.36 to 2019 | MW 1.33 / 1.34 on the Technical-Debt (Deprecation process) board.

Krinkle moved this task from Blocker to Deprecate/Remove on the MW-1.35-release board.Oct 11 2019, 10:45 PM

@Krinkle are we good to remove this now or should we wait a bit longer? If we are good to remove, I'll see about tackling this.

It was already removed, and it was done so in 1.34. It was mistakenly specified as hard-deprecated in 1.32 which is when it was soft-deprecated, and thus confusingly removed too soon within the same cycle.

In T220656#5174078, @gerritbot wrote:

Change 509589 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] SearchEngine: Remove deprecated unused method transformSearchTerm()

https://gerrit.wikimedia.org/r/509589

Krinkle closed this task as Resolved.Dec 20 2019, 5:54 PM

Krinkle removed a project: MW-1.34-notes (1.34.0-wmf.5; 2019-05-14).

Krinkle updated the task description. (Show Details)

Actually (hard) deprecate SearchEngine::transformSearchTerm and removeClosed, ResolvedPublic0 Estimated Story PointsActions