Page MenuHomePhabricator

pywikibot tests fails after flake8-quotes was updated
Closed, ResolvedPublic

Description

A new release 2.0.0 was published for flake8-quotes: https://pypi.org/project/flake8-quotes/#history
Tests are failing since them:

13:17:02 ./scripts/maintenance/diff_checker.py:81:30: Q003 Change outer quotes to avoid escaping inner quotes
13:17:02 ./scripts/maintenance/diff_checker.py:81:59: Q003 Change outer quotes to avoid escaping inner quotes
13:17:02 ./tests/link_tests.py:129:17: Q003 Change outer quotes to avoid escaping inner quotes
13:17:02 ./tests/link_tests.py:145:17: Q003 Change outer quotes to avoid escaping inner quotes
13:17:02 ./tests/link_tests.py:152:18: Q003 Change outer quotes to avoid escaping inner quotes
13:17:02 ./tests/link_tests.py:158:26: Q003 Change outer quotes to avoid escaping inner quotes
13:17:02 ./tests/link_tests.py:173:25: Q003 Change outer quotes to avoid escaping inner quotes
13:17:02 ./tests/link_tests.py:186:25: Q003 Change outer quotes to avoid escaping inner quotes
13:17:02 ./tests/link_tests.py:199:25: Q003 Change outer quotes to avoid escaping inner quotes
13:17:02 ./tests/file_tests.py:79:18: Q003 Change outer quotes to avoid escaping inner quotes
13:17:02 ./pywikibot/textlib.py:1573:13: Q003 Change outer quotes to avoid escaping inner quotes
13:17:02 ./pywikibot/site.py:3514:17: Q003 Change outer quotes to avoid escaping inner quotes
13:17:02 ERROR: InvocationError: '/src/.tox/flake8-py3/bin/flake8 --doctests'

Event Timeline

Xqt triaged this task as High priority.Apr 19 2019, 3:59 PM

Change 505266 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [tests] Ignore flake8-quotes error Q003

https://gerrit.wikimedia.org/r/505266

In T221462#5126475, @D3r1ck01 wrote:

I didn't know you filed this already, just seeing it now

Ja, please have a look to my upstream comment. I think we can wait for an upstream solution and. if we wants to merge some patches in meantime, to deactivate this error for a while

Sure, deactivating sounds great! And we wait for the upstream fix :)

xSavitar lowered the priority of this task from High to Medium.Apr 20 2019, 10:05 AM

Change 505266 merged by jenkins-bot:
[pywikibot/core@master] [tests] Ignore flake8-quotes error Q003

https://gerrit.wikimedia.org/r/505266

Xqt lowered the priority of this task from Medium to Lowest.Apr 20 2019, 10:51 AM

Change 506114 had a related patch set uploaded (by Dalba; owner: dalba):
[pywikibot/core@master] setup.py: Require flake8-quotes>=2.0.1

https://gerrit.wikimedia.org/r/506114

Change 506114 merged by jenkins-bot:
[pywikibot/core@master] setup.py: Require flake8-quotes>=2.0.1

https://gerrit.wikimedia.org/r/506114