Page MenuHomePhabricator

Dictionary only intermittently works
Closed, ResolvedPublicBUG REPORT

Description

From OTRS: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=11047793

I use Wikipedia Android application and I really liked its in-built dictionary. But there is a problem. Even when I'm online, when I click on define, it says, "no definition found". After clicking the 'Define' button for three to four time, it appears. So, please fix this issue. I'll be grateful to you.

Event Timeline

I took a look on this issue when working on T221666, and found that the issue might come from the WebView component.

The JavaScript method window.getSelection() does not work sometimes, and it will return null.

Even I moved the window.getSelection() to the Java layer and use the evaluateJavascript, the issue is still happening sometimes (but reduced).

ABorbaWMF subscribed.

Looks good to me on 2.7.280-beta-2019-05-01

The vast majority of the words I tested had definitions. I found a few words that did not have definitions, but only a handful