Page MenuHomePhabricator

MessageGroupStats only displayed for the priority language list even if prevent translation to other languages not set
Open, NormalPublic

Description

Currently if priority languages are set for a page, message group stats are only shown for those languages, even if there are translations for other language.

This behavior makes sense if the user has set Prevent translations to languages other than the priority languages while marking the page for translation, otherwise we should be displaying non-priority languages as well.

Event Timeline

abi_ created this task.Sat, Apr 20, 11:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSat, Apr 20, 11:54 AM
abi_ triaged this task as Normal priority.Sat, Apr 20, 11:56 AM
Elitre added a subscriber: Elitre.Sat, Apr 20, 5:10 PM
abi_ moved this task from Backlog to In Progress on the User-abi_ board.Mon, Apr 22, 3:51 AM

Change 505664 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Add non-priority languages to MessageGroupStats if priorityforce is false

https://gerrit.wikimedia.org/r/505664

abi_ added a comment.Mon, Apr 22, 8:26 PM

Please find the test cases for the patch below,

Test cases


TC #1 - If no priority language is set

  • Create the page, and mark it for translation.
  • Translate the page into any language.
  • Open message group statistics page.

Expected behavior

  1. You should see the languages that have translations.

  • On the message group statistics page, un-select Do not display languages which do not have any translations

Expected behavior

  1. You should see all the languages in the system.

TC #2 - If priority language is set, but priority force is not set

  • Create the page, and mark it for translation.
  • Mark the page for translation, set priority languages, but do not set prevent translation to non-priority language.
  • Translate the page into one of the priority language and a non priority languages.
  • Open message group statistics page.

Expected behavior

  1. You should see the priority language and the non-priority language that have translations.
  2. You should see the message - A translation administrator has set the priority languages for this group to {{priority languages}}.

  • On the message group statistics page, un-select Do not display languages which do not have any translations

Expected behavior

  1. In addition to languages that have translation, you should the list of all priority languages, even ones have no translation.

See images below,

TC #3 - If priority language is set, and priority force is set

  • Create the page, and mark it for translation.
  • Do not set priority languages.
  • Translate the page into a language say French.
  • When marking a page for translation set priority languages (atleast 2) and set prevent translation to non-priority language. Do not include French in the priority language list.
  • Translate the page into one of the priority language.
  • Open message group statistics page.

Expected behavior

  1. You should not see French in the table.
  2. You should see one of the translated priority languages selected in the table.
  3. You should see the message - A translation administrator has set the priority languages for this group to {{priority languages}} and blocked translation to non-priority languages.

  • On the message group statistics page, un-select Do not display languages which do not have any translations

Expected behavior

  1. You should see all priority languages listed even the ones that don't have any translation.

See images below,

abi_ moved this task from In Progress to Under Review on the User-abi_ board.Tue, Apr 23, 6:22 AM

Change 505664 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Add non-priority languages to MessageGroupStats if priorityforce is false

https://gerrit.wikimedia.org/r/505664

Elitre awarded a token.Fri, May 3, 2:06 PM
abi_ removed a project: Patch-For-Review.
abi_ moved this task from Under Review to QA on the User-abi_ board.
abi_ added a comment.Sun, May 12, 3:29 PM

Tested this on meta.wikimedia, and it seems to be working fine. See image below,