MessageGroupStats only displayed for the priority language list even if prevent translation to other languages not set
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	abi_
	Apr 20 2019, 11:54 AM

Description

Currently if priority languages are set for a page, message group stats are only shown for those languages, even if there are translations for other language.

This behavior makes sense if the user has set Prevent translations to languages other than the priority languages while marking the page for translation, otherwise we should be displaying non-priority languages as well.

Details

	Subject	Repo	Branch	Lines +/-
	Add non-priority languages to MessageGroupStats if priorityforce is false	mediawiki/extensions/Translate	master	+11 -3

Customize query in gerrit

Event Timeline

abi_ created this task.Apr 20 2019, 11:54 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2019, 11:54 AM

abi_ triaged this task as Medium priority.Apr 20 2019, 11:56 AM

• Elitre subscribed.Apr 20 2019, 5:10 PM

abi_ moved this task from Backlog to In Progress on the User-abi_ board.Apr 22 2019, 3:51 AM

Change 505664 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Add non-priority languages to MessageGroupStats if priorityforce is false

https://gerrit.wikimedia.org/r/505664

gerritbot added a project: Patch-For-Review.Apr 22 2019, 8:07 PM

Please find the test cases for the patch below,

Test cases

TC #1 - If no priority language is set

Create the page, and mark it for translation.
Translate the page into any language.
Open message group statistics page.

Expected behavior

You should see the languages that have translations.

On the message group statistics page, un-select Do not display languages which do not have any translations

Expected behavior

You should see all the languages in the system.

TC #2 - If priority language is set, but priority force is not set

Create the page, and mark it for translation.
Mark the page for translation, set priority languages, but do not set prevent translation to non-priority language.
Translate the page into one of the priority language and a non priority languages.
Open message group statistics page.

Expected behavior

You should see the priority language and the non-priority language that have translations.
You should see the message - A translation administrator has set the priority languages for this group to {{priority languages}}.

On the message group statistics page, un-select Do not display languages which do not have any translations

Expected behavior

In addition to languages that have translation, you should the list of all priority languages, even ones have no translation.

See images below,

TC #3 - If priority language is set, and priority force is set

Create the page, and mark it for translation.
Do not set priority languages.
Translate the page into a language say French.
When marking a page for translation set priority languages (atleast 2) and set prevent translation to non-priority language. Do not include French in the priority language list.
Translate the page into one of the priority language.
Open message group statistics page.

Expected behavior

You should not see French in the table.
You should see one of the translated priority languages selected in the table.
You should see the message - A translation administrator has set the priority languages for this group to {{priority languages}} and blocked translation to non-priority languages.

On the message group statistics page, un-select Do not display languages which do not have any translations

Expected behavior

You should see all priority languages listed even the ones that don't have any translation.

See images below,

abi_ moved this task from In Progress to Under Review on the User-abi_ board.Apr 23 2019, 6:22 AM

abi_ added a project: Language-Team (Language-2019-April-June).Apr 25 2019, 8:01 AM

abi_ moved this task from Backlog to In Review on the Language-Team (Language-2019-April-June) board.

abi_ moved this task from Backlog to group management on the MediaWiki-extensions-Translate board.Apr 27 2019, 10:17 AM

abi_ moved this task from group management to Backlog on the MediaWiki-extensions-Translate board.

Change 505664 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Add non-priority languages to MessageGroupStats if priorityforce is false

https://gerrit.wikimedia.org/r/505664

• Elitre awarded a token.May 3 2019, 2:06 PM

abi_ moved this task from In Review to Needs QA on the Language-Team (Language-2019-April-June) board.May 3 2019, 2:07 PM

abi_ removed a project: Patch-For-Review.

abi_ moved this task from Under Review to QA on the User-abi_ board.

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 3 2019, 3:00 PM

Tested this on meta.wikimedia, and it seems to be working fine. See image below,

abi_ moved this task from Needs QA to Done on the Language-Team (Language-2019-April-June) board.May 12 2019, 3:29 PM

Arrbee closed this task as Resolved.May 20 2019, 8:15 AM

	F29033650: image.png
	May 12 2019, 3:29 PM

	F28732645: image.png
	Apr 22 2019, 8:26 PM

	F28732659: image.png
	Apr 22 2019, 8:26 PM

	F28732723: image.png
	Apr 22 2019, 8:26 PM

MessageGroupStats only displayed for the priority language list even if prevent translation to other languages not setClosed, ResolvedPublicActions

Description

Details

Event Timeline

Test cases

TC #1 - If no priority language is set

TC #2 - If priority language is set, but priority force is not set

TC #3 - If priority language is set, and priority force is set

MessageGroupStats only displayed for the priority language list even if prevent translation to other languages not set
Closed, ResolvedPublic
Actions