HTML of edit page downloaded twice
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Schnark
	Apr 23 2019, 9:20 AM

Description

See the network log from Firefox (also reproducible on other browsers):

Bildschirmfoto_2019-04-23_11-07-23.png (944×1 px, 253 KB)

There is an entry with source "img", type "text/html", and URL "#null", which indicates downloading of a large amount HTML. At that point that HTML is already loaded, and additionally this second load tries to interpret the HTML as image.

This is caused by the rangeFix library, which creates an image with URL "#null" (https://phabricator.wikimedia.org/diffusion/GVED/browse/master/lib/rangefix/rangefix.js$54).

I don't know what the library is trying to do with that image, but it certainly should do it in a way that doesn't force the client to download that HTML again.

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (ac38ec869)	mediawiki/extensions/VisualEditor	master	+1 -1
	Update RangeFix 0.2.6 -> 0.2.7	VisualEditor/VisualEditor	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned Here: rGVEDac38ec8692e7: Merge "Restore re-activation hack"

Event Timeline

Schnark created this task.Apr 23 2019, 9:20 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2019, 9:20 AM

JTannerWMF moved this task from To Triage to FY 19-20 on the VisualEditor board.Apr 23 2019, 3:08 PM

JTannerWMF added a subscriber: Esanders.

Interesting. I think I used #null in that library to avoid a 404 request to /null, thinking that #null would not trigger another network request.

Esanders claimed this task.Apr 23 2019, 9:18 PM

Esanders triaged this task as High priority.

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.

Change 506011 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Update RangeFix 0.2.6 -> 0.2.7

https://gerrit.wikimedia.org/r/506011

gerritbot added a project: Patch-For-Review.Apr 23 2019, 9:52 PM

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Apr 23 2019, 9:52 PM

Change 506011 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Update RangeFix 0.2.6 -> 0.2.7

https://gerrit.wikimedia.org/r/506011

Change 506023 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ac38ec869)

https://gerrit.wikimedia.org/r/506023

Change 506023 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ac38ec869)

https://gerrit.wikimedia.org/r/506023

Esanders moved this task from Code review to Engineering QA on the VisualEditor (Current work) board.Apr 24 2019, 2:34 PM

Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 3:13 PM