Page MenuHomePhabricator

clear two step process in shex simple tool
Closed, ResolvedPublic5 Story Points

Description

Problem:
The "validate" button on https://tools.wmflabs.org/shex-simple/wikidata/packages/shex-webapp/doc/shex-simple.html?data=Endpoint:%20https://query.wikidata.org/sparql&hideData&manifest=[]&textMapIsSparqlQuery&schemaURL=https%3A%2F%2Fwikidata-shex.wmflabs.org%2Fwiki%2FSpecial%3AEntitySchemaText%2FE45 in the first step does not actually validate but fetch the list of entities to be checked based on a query. So It should be renamed to say "run query to fetch entities". Once the query has been run it should say "validate entities".

Acceptance criteria:

  • There is a clearly graspable two-step process of first fetching the entities and then validating them.

Ideally, when the user edits the query again afterwards (which means that the next Ctrl+Enter will fetch results again), the button label should update accordingly; if this turns out to be too much work, we can instead simply change the button label to some static string that’s always correct, e. g. “fetch query results or validate (Ctrl+Enter)”.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2019, 11:22 AM

I just found out that the “fetch results” part also happens as soon as a “change” event is fired on the input (e. g. when the input is unfocused), so the user might not even need to press Ctrl+Enter twice.

Michael added a subscriber: Michael.

As far as I can see, this was implemented in #45 and works as expected.

Lea_Lacroix_WMDE closed this task as Resolved.May 9 2019, 7:46 AM
Lea_Lacroix_WMDE added a subscriber: Lea_Lacroix_WMDE.

Check, we now have two steps with different labels.