Allow FallbackMethod to create their own SearchQuery
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	dcausse
	Apr 23 2019, 12:34 PM

Description

Needed by T212888 and probably further methods.
Currently the fallback methods are only allowed to augment the current search query via the elasticsearch suggest mechanism. This is too limiting a FallbackMethod should have the possibility to attach a new search query to the msearch request.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Allow fallback methods to send search queries	mediawiki/extensions/CirrusSearch	master	+191 -16
	Add a way to track msearch requests	mediawiki/extensions/CirrusSearch	master	+1 K -1 K

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		dcausse	T221621 Allow FallbackMethod to create their own SearchQuery
		Resolved	PRODUCTION ERROR	dcausse	T223449 Cannot search for anything: BadMethodCallException in search on some wikis

Event Timeline

dcausse created this task.Apr 23 2019, 12:34 PM

Restricted Application added a project: Discovery-Search. · View Herald TranscriptApr 23 2019, 12:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

dcausse triaged this task as Medium priority.Apr 23 2019, 12:35 PM

dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.

Change 506689 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Add a way to track msearch requests

https://gerrit.wikimedia.org/r/506689

gerritbot added a project: Patch-For-Review.Apr 26 2019, 3:04 PM

Change 507080 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Allow fallback methods to send search queries

https://gerrit.wikimedia.org/r/507080

dcausse moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.Apr 29 2019, 5:46 PM

Change 506689 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add a way to track msearch requests

https://gerrit.wikimedia.org/r/506689

Change 507080 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Allow fallback methods to send search queries

https://gerrit.wikimedia.org/r/507080

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.5; 2019-05-14).May 9 2019, 4:00 PM

Wargo added a subtask: T223449: Cannot search for anything: BadMethodCallException in search on some wikis.May 16 2019, 2:15 PM

Jdforrester-WMF closed subtask T223449: Cannot search for anything: BadMethodCallException in search on some wikis as Resolved.May 16 2019, 3:52 PM

Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 3:28 PM

dcausse moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.May 28 2019, 5:19 PM

• debt closed this task as Resolved.May 28 2019, 11:45 PM