Error `Cannot read property 'getScrollContainer' of null` when saving on mobile
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DLynch
	Apr 23 2019, 4:45 PM

Description

The following error occurs after saving on mobile VE:

VM31 jquery.js:3818 jQuery.Deferred exception: Cannot read property 'getScrollContainer' of null TypeError: Cannot read property 'getScrollContainer' of null
    at VeUiMWSurface.ve.ui.Surface.toggleMobileGlobalOverlay (http://dev.wiki.local.wmftest.net:8080/w/extensions/VisualEditor/lib/ve/src/ui/ve.ui.Surface.js?88f5b:608:36)
    at http://dev.wiki.local.wmftest.net:8080/w/extensions/VisualEditor/lib/ve/src/ui/ve.ui.Surface.js?88f5b:587:16
    at fire (http://dev.wiki.local.wmftest.net:8080/w/resources/lib/jquery/jquery.js?6a07d:3268:31)
    at Object.fireWith [as resolveWith] (http://dev.wiki.local.wmftest.net:8080/w/resources/lib/jquery/jquery.js?6a07d:3398:7)
    at Object.deferred.(anonymous function) [as resolve] (http://dev.wiki.local.wmftest.net:8080/w/resources/lib/jquery/jquery.js?6a07d:3736:36)
    at http://dev.wiki.local.wmftest.net:8080/w/resources/lib/ooui/oojs-ui-windows.js?1ebec:1522:21
    at mightThrow (http://dev.wiki.local.wmftest.net:8080/w/resources/lib/jquery/jquery.js?6a07d:3534:29)
    at process (http://dev.wiki.local.wmftest.net:8080/w/resources/lib/jquery/jquery.js?6a07d:3602:12) undefined

Because it's in a Deferred, it doesn't actually interfere with anything.

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (ac38ec869)	mediawiki/extensions/VisualEditor	master	+1 -1
	toggleMobileGlobalOverlay: check whether the target exists before using it	VisualEditor/VisualEditor	master	+6 -3

Customize query in gerrit

Related Objects

Mentioned Here: rGVEDac38ec8692e7: Merge "Restore re-activation hack"

Event Timeline

DLynch created this task.Apr 23 2019, 4:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2019, 4:45 PM

Change 505822 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] toggleMobileGlobalOverlay: check whether the target exists before using it

https://gerrit.wikimedia.org/r/505822

gerritbot added a project: Patch-For-Review.Apr 23 2019, 4:52 PM

DLynch moved this task from Incoming to Code review on the VisualEditor (Current work) board.Apr 23 2019, 4:59 PM

Change 505822 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] toggleMobileGlobalOverlay: check whether the target exists before using it

https://gerrit.wikimedia.org/r/505822

Change 506023 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ac38ec869)

https://gerrit.wikimedia.org/r/506023

Change 506023 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ac38ec869)

https://gerrit.wikimedia.org/r/506023

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 24 2019, 11:00 AM

DLynch moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Apr 24 2019, 1:23 PM

Ladsgroup removed a project: Patch-For-Review.May 22 2019, 9:20 AM

JTannerWMF added a project: Skipped QA.May 23 2019, 6:44 PM

• ppelberg closed this task as Resolved.Jun 18 2019, 12:26 AM