Improve Block handling where User::isBlocked() was used previously
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	dbarratt
	Apr 23 2019, 5:44 PM

Project Tags

Referenced Files

None

Subscribers

Description

Problem
User::isBlocked() was deprecated in T209004 but the uses in core were replaced with User::getBlock() which is not always appropriate

Solution
Audit previous usages of User::isBlocked() and replace with the appropriate replacement.

Current patch makes the following changes:

Users are only blocked from autopromote if their block is sitewide
Users are only blocked from deleting revisions of a page if they are blocked from it
Users are only blocked from editing page tags if (1) they are blocked from it, or (2) $wgBlockDisablesLogin is true and a logged out user cannot perform the tagging action in question
Users who can normally unblock themselves cannot unblock themselves if their block applies to the unblockself right

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Improve Block handling where User::isBlocked() was used previously	Dbarratt	mediawiki/core	master	+203 -63

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		dbarratt	T221682 Improve Block handling where User::isBlocked() was used previously
Resolved		dbarratt	T209004 Deprecate User::isBlocked()
Resolved		dbarratt	T228479 Autopromote is blocked by a Partial Block
Resolved		dbarratt	T228486 Partially blocked users cannot delete revisions
Resolved	BUG REPORT	dbarratt	T221444 Partially blocked users cannot tag revisions on unrelated pages, nor add, deactive or delete tags
Resolved		Tchanders	T228948 PermissionManager::isBlockedFrom() can return true even if the user does not have a block
Resolved		dbarratt	T228534 Users with partial access to change user rights should not be blocked with a partial block
Resolved		dbarratt	T228538 Remove TODO for unblockself check
Resolved		dbarratt	T228539 Partially blocked users should not be prevented from using the importImages maintenance script

Event Timeline

dbarratt created this task.Apr 23 2019, 5:44 PM

Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptApr 23 2019, 5:44 PM

dbarratt added a subtask: T209004: Deprecate User::isBlocked().Apr 23 2019, 5:44 PM

Change 494497 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/core@master] Deprecate User::isBlocked()

https://gerrit.wikimedia.org/r/494497

gerritbot added a project: Patch-For-Review.Apr 23 2019, 5:46 PM

@dbarratt Should this be moved to the sprint?

Uhhh... I need to update it since we've changed our direction

dbarratt renamed this task from Remove use of User::isBlocked() from core to Improve Block handling where User::isBlocked() was used previously.Apr 30 2019, 12:53 AM

dbarratt updated the task description. (Show Details)

dbarratt set the point value for this task to 3.May 7 2019, 10:30 PM

• Niharika moved this task from Untriaged to Cards ready for development on the Anti-Harassment-Team board.May 8 2019, 5:10 PM

The current patchset (PS22) makes the following changes:

Users are only blocked from autopromote if their block is sitewide
Users are only blocked from deleting revisions of a page if they are blocked from it
Users are only blocked from editing page tags if (1) they are blocked from it, or (2) $wgBlockDisablesLogin is true and a logged out user cannot perform the tagging action in question
Users who can normally unblock themselves cannot unblock themselves if their block applies to the unblockself right

Should we discuss these here? I'm thinking to include @Niharika and @SPoore in the conversation.

It might be easier to move forward with these if they were separate patches/tasks...

dbarratt closed subtask T209004: Deprecate User::isBlocked() as Resolved.May 22 2019, 6:06 PM

• Niharika triaged this task as Medium priority.Jun 5 2019, 6:24 PM

• Niharika moved this task from Cards ready for development to Lāmed - ל on the Anti-Harassment-Team board.

• Niharika edited projects, added: Anti-Harassment-Team (Lāmed - ל); removed: Anti-Harassment-Team.

Tchanders moved this task from Backlog to User blocking on the MediaWiki-User-management board.Jun 5 2019, 8:51 PM

I can't remember if we said we'd split this up, but if so then the tagging is already filed as T221444

In T221682#5238307, @Tchanders wrote:

I can't remember if we said we'd split this up, but if so then the tagging is already filed as T221444

We said we'd split the patches but keep the same ticket with a complete description of changes we are making. Copying your last comment in the ticket description for that.

• Niharika updated the task description. (Show Details)Jun 5 2019, 9:28 PM

• Niharika edited projects, added: Anti-Harassment-Team (The Letter Song); removed: Anti-Harassment-Team (Lāmed - ל).Jun 20 2019, 6:23 PM

dbarratt claimed this task.Jul 18 2019, 5:31 PM

dbarratt moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.

dbarratt added a subtask: T221444: Partially blocked users cannot tag revisions on unrelated pages, nor add, deactive or delete tags.Jul 18 2019, 11:36 PM

dbarratt added a project: Epic.Jul 19 2019, 6:18 PM

Change 494497 abandoned by Dbarratt:
Improve Block handling where User::isBlocked() was used previously

https://gerrit.wikimedia.org/r/494497

dbarratt moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Jul 19 2019, 6:35 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 19 2019, 7:11 PM

Tchanders closed subtask T228538: Remove TODO for unblockself check as Resolved.Jul 29 2019, 2:08 PM

dbarratt closed subtask T228534: Users with partial access to change user rights should not be blocked with a partial block as Resolved.Jul 29 2019, 5:08 PM