Page MenuHomePhabricator
Create Task
Maniphest T221901

[Regression pre-wmf.2] Uncaught TypeError: selection.containsCell is not a function appears when clicking on a cell after a delete row/column operation
Closed, ResolvedPublic
Actions

Description

Steps to replicate:

  1. Select a table cell
  2. Delete that row or column
  3. Now click on any cell

There is an error in the console:
Uncaught TypeError: selection.containsCell is not a function

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (b68520b6d)mediawiki/extensions/VisualEditormaster+1 -1
Check selection is a TableSelection before looking for cellsVisualEditor/VisualEditormaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Apr 25 2019, 9:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 25 2019, 9:19 PM
Ryasmeen mentioned this in T221286: [Regression wmf.1] Table selection not active after row/column operation.Apr 25 2019, 9:21 PM
gerritbot added a comment.Apr 25 2019, 9:59 PM

Change 506560 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Check selection is a TableSelection before looking for cells

https://gerrit.wikimedia.org/r/506560

gerritbot added a project: Patch-For-Review.Apr 25 2019, 9:59 PM
Esanders claimed this task.Apr 25 2019, 9:59 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Apr 27 2019, 4:24 AM

Change 506560 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Check selection is a TableSelection before looking for cells

https://gerrit.wikimedia.org/r/506560

gerritbot added a comment.Apr 27 2019, 4:27 AM

Change 506852 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b68520b6d)

https://gerrit.wikimedia.org/r/506852

gerritbot added a comment.Apr 27 2019, 3:18 PM

Change 506852 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b68520b6d)

https://gerrit.wikimedia.org/r/506852

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 27 2019, 4:00 PM
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Apr 29 2019, 5:43 PM
Ryasmeen edited projects, added Verified; removed Patch-For-Review.Apr 30 2019, 9:35 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
ppelberg closed this task as Resolved.Jun 18 2019, 4:32 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 18 2019, 4:32 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits