Page MenuHomePhabricator

Add abi to l10n-watchers group in Gerrit
Closed, ResolvedPublic

Description

Hello,

I'm a part of the Language team. I'd like to be added to the l10n-watchers group so that I can review and override Jenkin when patches from translatewiki.net fail due to HTML injection checks.

Event Timeline

abi_ created this task.Apr 27 2019, 10:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2019, 10:46 AM

Hi @abi_, any current member of the group should be able to do that.

@Nikerabbit You can do it by going to https://gerrit.wikimedia.org/r/admin/groups/1531,members and adding abi to the members textbox that should be displayed. See my interface for wikimedia-cz group, for instance:

I am not sure I am allowed to do that per the new privilege policy.

I am not sure I am allowed to do that per the new privilege policy.

You should be allowed to do that. l10n-bot-watcher is a group owned by itself, meaning that current members (you and Raimond) should be able to add members to that group.

Is that not the case?

Administrators can also add members if needed, but hopefully you should be able to manage as well.

@thcipriani He didn't mean "not able technically", but policy-side.

greg added a subscriber: greg.May 13 2019, 4:54 PM

@thcipriani He didn't mean "not able technically", but policy-side.

The relevant policy is here: https://www.mediawiki.org/wiki/Gerrit/Privilege_policy

If that doesn't clarify things for you, please reach out to TechComm.

Nikerabbit closed this task as Resolved.May 13 2019, 5:47 PM
Nikerabbit claimed this task.

The policy states:

To request membership in another group, create a new task under the Gerrit-Privilege-Requests project in Phabricator.

If there is a consensus of trusted developers on the Phabricator task, any of the Gerrit administrators can resolve the request.

I did participate in drafting of the policy (as a TechCom member), and my understanding of the intention is that only a trusted group of users can add members to groups that give +2 to something deployed to Wikimedia production. l10n-bot-watcher group, practically speaking, gives that right.

Given that this task has been open for a while, and no opposition has been raised, and that multiple people have said that I can do it myself, I believe that due process has been followed and I have added @abi_ to the group.