Page MenuHomePhabricator

VisualEditor suggested edit summary overrides keyboard shortcut to publish edit
Closed, ResolvedPublic

Description

OS: Windows 7
Browser: Chrome 73.0.3683.103

Steps to reproduce:

  1. Publish an edit somewhere and use the edit summary "+++++"
  2. Make another edit, and click "Publish changes..."
  3. Write the edit summary "+"
  4. Use the shortcut for publishing the edit, e.g. ctrl-enter on Windows or cmd-enter on Mac.

Expected:

  • My edit is published.

Actual:

  • The first edit summary in the suggested edit summaries is selected as soon as I enter the first +, hitting ctrl-enter replaces my current edit summary with the suggested one, and the edit is not published until I hit ctrl-enter again.

Highlighting the first edit summary makes sense, as does making enter replace it, but ctrl-enter should probably override that and publish.

Type +, first summary is selected:

ctrl-enter chooses first summary instead of publishing:

Event Timeline

Deskana created this task.Apr 28 2019, 8:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2019, 8:21 AM
Deskana renamed this task from VisualEditor suggested edit summary overrides shortcut to publish edit to VisualEditor suggested edit summary overrides keyboard shortcut to publish edit.Apr 28 2019, 8:23 AM
Esanders closed this task as Resolved.Apr 28 2019, 4:39 PM
Esanders claimed this task.
Esanders added a subscriber: Esanders.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 28 2019, 4:39 PM

Excellent. Thanks @Esanders!