Maniphest T222079

mediawiki.widgets.TitleWidget using old icons
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Apr 29 2019, 4:08 PM

Description

Currently using one-rounded-corner versions:

Should be using article-style icons from OOUI:

n.b. OOUI doesn't have "disambiguation" (forked arrows) and "not found" (question mark) variants yet – T222088

Details

Subject	Repo	Branch	Lines +/-
Update OOUI icons names for article icons in link cache	mediawiki/extensions/VisualEditor	master	+4 -4
mw.widgets.TitleWidget: Replace last local icons with new OOUI ones	mediawiki/core	master	+2 -40
mw.widgets.TitleWidget: Update icons, use OOUI where possible	mediawiki/core	master	+16 -39

Customize query in gerrit

Related Objects

Mentioned In: T222088: OOUI's article icons miss two use cases – articles which are not found, and disambiguation articles
Mentioned Here: T222088: OOUI's article icons miss two use cases – articles which are not found, and disambiguation articles

Event Timeline

Esanders created this task.Apr 29 2019, 4:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2019, 4:08 PM

Change 507057 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] mw.widgets.TitleWidget: Update icons, use OOUI where possible

https://gerrit.wikimedia.org/r/507057

gerritbot added a project: Patch-For-Review.Apr 29 2019, 4:10 PM

Change 507063 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] MediaDialog: Use new icons

https://gerrit.wikimedia.org/r/507063

This is a UI standardisation issue, not a problem with the OOUI library.

Jdforrester-WMF moved this task from Unsorted to Icons standardization on the UI-Standardization board.Apr 29 2019, 4:49 PM

Jdforrester-WMF assigned this task to Esanders.Apr 29 2019, 4:51 PM

Jdforrester-WMF mentioned this in T222088: OOUI's article icons miss two use cases – articles which are not found, and disambiguation articles.

Jdforrester-WMF updated the task description. (Show Details)

Change 507057 merged by jenkins-bot:
[mediawiki/core@master] mw.widgets.TitleWidget: Update icons, use OOUI where possible

https://gerrit.wikimedia.org/r/507057

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 29 2019, 6:01 PM

Partially done; can't progress until T222088 is fixed.

Jdforrester-WMF changed the task status from Stalled to Open.May 8 2019, 3:54 PM

Change 508858 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] mw.widgets.TitleWidget: Replace last local icons with new OOUI ones

https://gerrit.wikimedia.org/r/508858

gerritbot added a project: Patch-For-Review.May 8 2019, 4:06 PM

Change 508858 merged by jenkins-bot:
[mediawiki/core@master] mw.widgets.TitleWidget: Replace last local icons with new OOUI ones

https://gerrit.wikimedia.org/r/508858

Jdforrester-WMF closed this task as Resolved.May 8 2019, 4:51 PM

Jdforrester-WMF edited projects, added MW-1.34-notes (1.34.0-wmf.5; 2019-05-14); removed Patch-For-Review, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).

Change 523912 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update OOUI icons names for article icons in link cache

https://gerrit.wikimedia.org/r/523912

gerritbot added a project: Patch-For-Review.Jul 17 2019, 12:10 PM

Change 523912 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update OOUI icons names for article icons in link cache