Page MenuHomePhabricator

Add data step image shadow gets cut off
Closed, ResolvedPublicBUG REPORT

Description

User story: N/A

We have this:
Image/shadow on the right-hand side gets cut off (tested on Test Commons) on Add data step

screencapture-test-commons-wikimedia-org-wiki-Special-UploadWizard-2019-04-29-12_31_33.png (1×2 px, 502 KB)

We want this:

Stop cutting off right side of image/shadow

Acceptance Criteria:

Can be tested on https://commons.wikimedia.beta.wmflabs.org/wiki/Special:UploadWizard

  • Stop cutting off right side of image/shadow

QA Results

ACStatusDetails
1T222083#5188311

Event Timeline

Change 507294 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Don't cut off image shadow in metadata step

https://gerrit.wikimedia.org/r/507294

Change 507294 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Don't cut off image shadow in metadata step

https://gerrit.wikimedia.org/r/507294

Edtadros added a subscriber: Edtadros.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):Acceptance Criteria:

Can be tested on https://commons.wikimedia.beta.wmflabs.org/wiki/Special:UploadWizard

Stop cutting off right side of image/shadow

I tried this with an ultrawide image in addition to a normal aspect ratio image.

Screen Shot 2019-05-16 at 4.10.06 PM.png (1×1 px, 390 KB)

Verified on production.