The reason we have had breakages on 2 of our Civi-upgrades on cancelling recurring is that we some something unique and special in the way we record them - which means core doesn't get on well with us....
We have hacked past this and now have permanently solved one of 3 issues with how we record recurrings
We were not recording the payment processor - this is now fixed in conjunction with the metrics issueWe are recording Recurrings as Completed when they are 'In Progress'
- We are misusing the installments field
I dug into 2 & 3 in conjunction with the upgrade & metrics issue but in the end decided that I was getting scope creep & it needed to be it's own ticket.Hence this
A good chunk of the work is done here https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/506580/
But it made me think potentially we *should* use a status for 'Processing' - but we should collaborate with others on that - logged as https://lab.civicrm.org/dev/core/issues/905 & I will try to discuss with others....