Left rail should not show on Add data step if there's just one file
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• PDrouin-WMF
	Apr 30 2019, 4:09 PM

Description

User story: n/a

We have this:
Currently (on Beta) the "Add data" step for UW shows the left nav rail, even when only one file is being uploaded. It's unnecessary, as there is no other file to navigate to.

We want this:
When only one file is being uploaded, the left rail shouldn't show and the content block (image & input fields) is centered.

Please see T220429 for "Add data" instructional text and button copy, as it's shown here in the mock as well.

Acceptance Criteria:

Can be tested on Can be tested on https://commons.wikimedia.beta.wmflabs.org/wiki/Special:UploadWizard

Left rail doesn't show for only one file being uploaded
Content block is centered

Details

	Subject	Repo	Branch	Lines +/-
	Don't show metadata menu when there's only 1 file	mediawiki/extensions/UploadWizard	wmf/1.34.0-wmf.3	+36 -11
	Don't show metadata menu when there's only 1 file	mediawiki/extensions/UploadWizard	master	+36 -11

Customize query in gerrit

Related Objects

Mentioned In: T220429: Update UploadWizard describe step with text explaining what "publish" actually does
Mentioned Here: T220429: Update UploadWizard describe step with text explaining what "publish" actually does

Event Timeline

• PDrouin-WMF created this task.Apr 30 2019, 4:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2019, 4:09 PM

• PDrouin-WMF renamed this task from [stub] Left rail should not show on Add data step if there's just one file to Left rail should not show on Add data step if there's just one file.Apr 30 2019, 10:16 PM

• PDrouin-WMF added projects: Structured-Data-Team-Current-Work, Multimedia.

• PDrouin-WMF updated the task description. (Show Details)

• PDrouin-WMF added a subscriber: • Ramsey-WMF.

• PDrouin-WMF mentioned this in T220429: Update UploadWizard describe step with text explaining what "publish" actually does.Apr 30 2019, 10:22 PM

• Ramsey-WMF triaged this task as High priority.May 1 2019, 3:50 PM

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.

• Ramsey-WMF assigned this task to matthiasmullie.May 1 2019, 7:00 PM

Change 507750 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Don't show metadata menu when there's only 1 file

https://gerrit.wikimedia.org/r/507750

gerritbot added a project: Patch-For-Review.May 2 2019, 9:12 AM

matthiasmullie moved this task from To Do to Code Review on the Structured-Data-Team-Current-Work board.May 2 2019, 9:12 AM

From our meeting earlier, with an individual file, centering the content block looks weird. Should be left-aligned.

Change 507750 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Don't show metadata menu when there's only 1 file

https://gerrit.wikimedia.org/r/507750

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 3 2019, 11:00 AM

• PDrouin-WMF moved this task from Doing 📝 to Done/Handed off 📮 on the SDC Design board.May 3 2019, 9:52 PM

matthiasmullie reassigned this task from matthiasmullie to Edtadros.May 7 2019, 6:14 AM

matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.

matthiasmullie updated the task description. (Show Details)

matthiasmullie subscribed.

Change 508526 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@wmf/1.34.0-wmf.3] Don't show metadata menu when there's only 1 file

https://gerrit.wikimedia.org/r/508526

Change 508526 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@wmf/1.34.0-wmf.3] Don't show metadata menu when there's only 1 file

https://gerrit.wikimedia.org/r/508526

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.3; 2019-04-30); removed MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 7 2019, 11:00 AM

The spec on this changed: UploadWizard content went from being centered to left justified with the "learn" box. Works as newly specced on production.

Left rail should not show on Add data step if there's just one fileClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Left rail should not show on Add data step if there's just one file
Closed, ResolvedPublic
Actions