Page MenuHomePhabricator

Update icons in AMC
Closed, ResolvedPublic2 Estimated Story Points

Assigned To
Authored By
alexhollender_WMF
Apr 30 2019, 9:07 PM
Referenced Files
F29406081: T222228-5.png
Jun 9 2019, 4:16 PM
F29406072: T222228-3.png
Jun 9 2019, 4:16 PM
F29406064: T222228-2.png
Jun 9 2019, 4:16 PM
F29406078: T222228-4.png
Jun 9 2019, 4:16 PM
F29406047: T222228-0.png
Jun 9 2019, 4:16 PM
F29406056: T222228-1.png
Jun 9 2019, 4:16 PM
F29206276: info.svg
May 22 2019, 4:41 PM
F29189804: recent changes - ltr.svg
May 21 2019, 7:32 PM

Description

Description

We will need to replace a few of the icons used in AMC mode. At least one of the icon changes will be relevant for all users (contributions icon).

Icons to replace

link/actionltr svgrtl svglocation in UI
community portalmain menu
contributions (all logged in users, AMC and non-AMC)main menu (eventually user menu)
info(same)article "more" menu
special pagesmain menu

QA Results

link/actionltr svgrtl svgdetails
AC1: community portalT222228#5245662
AC2: contributions (all logged in users, AMC and non-AMC)T222228#5245662
AC3: infoT222228#5245662
AC4: special pagesT222228#5245662

Event Timeline

alexhollender_WMF triaged this task as Medium priority.
alexhollender_WMF updated the task description. (Show Details)
alexhollender_WMF added a subscriber: ovasileva.

@ovasileva this is ready to be implemented

@alexhollender - since we're not currently using recent changes in the menu, we'll add that icon when we add recent changes back to the main menu

ovasileva updated the task description. (Show Details)
ovasileva set the point value for this task to 2.
alexhollender_WMF removed the point value for this task.
ovasileva set the point value for this task to 2.May 22 2019, 4:51 PM

Change 514707 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/MinervaNeue@master] Updating icons for AMC mode

https://gerrit.wikimedia.org/r/514707

Jdrewniak added a subscriber: Jdrewniak.

Change 514707 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Updating icons for AMC mode

https://gerrit.wikimedia.org/r/514707

Edtadros added a subscriber: Edtadros.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA Steps

link/actionltr svgrtl svg
Main Menu non-AMC
T222228-0.png (2×1 px, 250 KB)
T222228-3.png (2×1 px, 187 KB)
Main Menu AMC
T222228-1.png (2×1 px, 268 KB)
T222228-4.png (2×1 px, 241 KB)
More Menu AMC
T222228-2.png (2×1 px, 269 KB)
T222228-5.png (2×1 px, 198 KB)
AC1: community portal
AC2: contributions (all logged in users, AMC and non-AMC)
AC3: info
AC4: special pages