Description

As discovered in T216961#5138754, the citation icon changed from gray to white. This is currently not live in production, but will be shortly (2nd May). It can currently be seen on test wiki: https://test.m.wikipedia.org/wiki/Paris

Before:

de.m.wikipedia.org_w_index.php_title=Axel_Krau%C3%9Fe&oldid=185986567&mobileaction=toggle_view_mobile(iPhone 6_7_8) (3).png (1×750 px, 191 KB)

After:

Screen Shot 2019-04-25 at 16.09.02.png (1×1 px, 795 KB)

The bug was introduced in https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/506425/

QA steps

On beta cluster, configure the heading matches the icon color.

QA Results

Status	Details
✅ Passed	T222314#5166489

Details

	Subject	Repo	Branch	Lines +/-
	🚑 Restore the gray references icon color	mediawiki/extensions/MobileFrontend	master	+4 -0

Customize query in gerrit

Related Objects

Mentioned Here: T216961: In mobile view, if a reference contains a link, the link may be positioned improperly in the footnote tooltip

Event Timeline

Jdlrobson created this task.May 1 2019, 10:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2019, 10:22 PM

Jdlrobson updated the task description. (Show Details)May 1 2019, 10:29 PM

Change 507714 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] 🚑 Restore the gray references icon color

https://gerrit.wikimedia.org/r/507714

gerritbot added a project: Patch-For-Review.May 1 2019, 10:33 PM

Aklapper added a project: MobileFrontend.May 2 2019, 9:49 AM

ovasileva triaged this task as Medium priority.May 2 2019, 1:47 PM

ovasileva moved this task from Incoming to Upcoming on the Web-Team-Backlog board.

Change 507714 merged by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] 🚑 Restore the gray references icon color

https://gerrit.wikimedia.org/r/507714

Jdlrobson assigned this task to Edtadros.May 6 2019, 9:53 PM

Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4); removed Web-Team-Backlog.

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from To Do to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 6 2019, 10:00 PM

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

Edtadros updated the task description. (Show Details)May 8 2019, 9:55 AM

Looks good!

	F28771355: Screen Shot 2019-04-25 at 16.09.02.png
	May 1 2019, 10:22 PM

	F28325617: de.m.wikipedia.org_w_index.php_title=Axel_Krau%C3%9Fe&oldid=185986567&mobileaction=toggle_view_mobile(iPhone 6_7_8) (3).png
	May 1 2019, 10:22 PM

Regression: Citation icon in reference drawer changed from gray to whiteClosed, ResolvedPublicActions