Page MenuHomePhabricator
Create Task
Maniphest T222329

Special:Search generates "TypeError: this.pushPending is not a function"
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

In the JavaScript console the error

TypeError: this.pushPending is not a function

is reported.

This problem happens since rMW8414e3c4d0c2: Update OOUI to v0.31.4 (@Jdforrester-WMF @Volker_E).

Details

SubjectRepoBranchLines +/-
SearchInputWidget: Replace pushPending hackmediawiki/corewmf/1.34.0-wmf.3+1 -13
SearchInputWidget: Replace pushPending hackmediawiki/coremaster+1 -13
Customize query in gerrit

Related Objects

Event Timeline

Fomafix created this task.May 2 2019, 5:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 2 2019, 5:07 AM
Fomafix updated the task description. (Show Details)May 2 2019, 5:10 AM
Fomafix added a subscriber: Volker_E.
Aklapper merged a task: T222346: [Bug] Drop-down doesn't appear when typing in the Wikidata search box.May 2 2019, 9:53 AM
Aklapper added subscribers: Lea_Lacroix_WMDE, Moebeus, Michael and 5 others.
Aklapper added a parent task: T220728: 1.34.0-wmf.3 deployment blockers.May 2 2019, 9:56 AM

Tentatively setting T220728 as parent task. Please feel free to correct me.

Aklapper mentioned this in T222333: Wikidata search dropdown is blank when there's an exact name match.May 2 2019, 11:06 AM
thcipriani triaged this task as Unbreak Now! priority.May 2 2019, 3:32 PM
thcipriani subscribed.
In T222329#5152446, @Aklapper wrote:

Tentatively setting T220728 as parent task. Please feel free to correct me.

Setting as unbreak now since this is a train blocker. Would also like other opinions here: @Jdforrester-WMF ?

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMay 2 2019, 3:32 PM
Volker_E added a subscriber: Esanders.May 2 2019, 3:43 PM
Volker_E added a comment.May 2 2019, 3:46 PM

Seems to be caused by patch for T220204.

Jdforrester-WMF lowered the priority of this task from Unbreak Now! to High.May 2 2019, 3:58 PM
In T222329#5153284, @thcipriani wrote:
In T222329#5152446, @Aklapper wrote:

Tentatively setting T220728 as parent task. Please feel free to correct me.

Setting as unbreak now since this is a train blocker. Would also like other opinions here: @Jdforrester-WMF ?

I don't think this is a train blocker. JS error and loss of "pending" styling are the only outcomes. De-tagging.

Jdforrester-WMF added a project: MediaWiki-Search.May 2 2019, 3:58 PM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptMay 2 2019, 3:58 PM
Jdforrester-WMF removed a parent task: T220728: 1.34.0-wmf.3 deployment blockers.May 2 2019, 3:58 PM
Esanders added a comment.May 2 2019, 4:14 PM

Exposed by OOUI, but is a downstream issue.

gerritbot added a comment.May 2 2019, 4:17 PM

Change 507823 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] SearchInputWidget: Replace pushPending hack

https://gerrit.wikimedia.org/r/507823

gerritbot added a project: Patch-For-Review.May 2 2019, 4:17 PM
debt moved this task from needs triage to watching / waiting on the Discovery-Search board.May 2 2019, 5:09 PM
gerritbot added a comment.May 2 2019, 7:08 PM

Change 507823 merged by jenkins-bot:
[mediawiki/core@master] SearchInputWidget: Replace pushPending hack

https://gerrit.wikimedia.org/r/507823

gerritbot added a comment.May 2 2019, 7:16 PM

Change 507863 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/core@wmf/1.34.0-wmf.3] SearchInputWidget: Replace pushPending hack

https://gerrit.wikimedia.org/r/507863

gerritbot added a comment.May 2 2019, 7:35 PM

Change 507863 merged by jenkins-bot:
[mediawiki/core@wmf/1.34.0-wmf.3] SearchInputWidget: Replace pushPending hack

https://gerrit.wikimedia.org/r/507863

Stashbot added a comment.May 2 2019, 7:39 PM

Mentioned in SAL (#wikimedia-operations) [2019-05-02T19:39:44Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.3/includes/widget/SearchInputWidget.php: Hot-deploy T222329 fix part 1 (duration: 00m 53s)

Stashbot added a comment.May 2 2019, 7:40 PM

Mentioned in SAL (#wikimedia-operations) [2019-05-02T19:40:54Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.3/resources/src/mediawiki.widgets/mw.widgets.SearchInputWidget.js: Hot-deploy T222329 fix part 2 (duration: 00m 50s)

Jdforrester-WMF closed this task as Resolved.May 2 2019, 7:41 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF edited projects, added MW-1.34-notes (1.34.0-wmf.3; 2019-04-30); removed Patch-For-Review.

Now deployed.

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.4; 2019-05-07); removed MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).May 2 2019, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL