Page MenuHomePhabricator
Create Task
Maniphest T222346

[Bug] Drop-down doesn't appear when typing in the Wikidata search box
Closed, ResolvedPublic
Actions

Description

Since 1 May 2019 some users noticed a malfunction with the Wikidata search box (top right corner).

Steps to reproduce:

  • click on the search box
  • type "test"
  • the turning wheel icon appears, then disappears, and the suggestion drop-down doesn't show up
  • when pressing the arrow down key or enter, it appears

Note: depending on the word that is typed, the menu seems to appear or not. "test" doesn't work, "foo" works.

Tested so far on Chrome and Firefox.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasewmf/1.34.0-wmf.4+1 -7Revert "Close entityselector after selecting exact match"
mediawiki/extensions/Wikibasemaster+1 -7Revert "Close entityselector after selecting exact match"
Customize query in gerrit

Related Objects

Event Timeline

Lea_Lacroix_WMDE created this task.May 2 2019, 9:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 2 2019, 9:15 AM
Lucas_Werkmeister_WMDE added a subscriber: Lucas_Werkmeister_WMDE.EditedMay 2 2019, 9:15 AM

Console error:

TypeError: this.pushPending is not a function

Michael added a subscriber: Michael.May 2 2019, 9:23 AM
In T222346#5152365, @Lucas_Werkmeister_WMDE wrote:

Console error:

TypeError: this.pushPending is not a function

Interesting! I don't get this on wikidata.org. how/where do you see this?

Lucas_Werkmeister_WMDE added a comment.May 2 2019, 9:27 AM

Sorry, it’s unrelated – I got that on Special:Search, it happens when you type into the search box there (instead of the one on the top right of every page).

Moebeus added a subscriber: Moebeus.May 2 2019, 9:47 AM
Moebeus removed a subscriber: Moebeus.
Moebeus added a comment.May 2 2019, 9:50 AM

I'd like to add that the same problem also affects property/value suggestions. Started evening/late afternoon May 1. Tested Google, Firefox.

Moebeus added a subscriber: Moebeus.May 2 2019, 9:50 AM
Aklapper closed this task as a duplicate of T222329: Special:Search generates "TypeError: this.pushPending is not a function".May 2 2019, 9:53 AM
Lucas_Werkmeister_WMDE reopened this task as Open.May 2 2019, 11:41 AM

@Aklapper sorry for the confusion – I happened to also notice the pushPending issue, but I think it’s independent of this one.

debt moved this task from needs triage to watching / waiting on the Discovery-Search board.May 2 2019, 5:06 PM
debt added a subscriber: debt.

Moving this to our watching column, as we don't have any front end engineers to help out.

Lucas_Werkmeister_WMDE added a comment.May 2 2019, 9:07 PM

Might be the same issue as T222333: Wikidata search dropdown is blank when there's an exact name match, not sure.

Pigsonthewing added a subscriber: Pigsonthewing.May 4 2019, 12:26 PM
Nikki added a subscriber: Nikki.May 4 2019, 2:07 PM

Is this perhaps caused by the fix for T172937? The timing looks like it would fit.

Krinkle updated the task description. (Show Details)May 4 2019, 5:09 PM
Lucas_Werkmeister_WMDE added a comment.May 9 2019, 11:53 AM

@Nikki yeah, looking at the patch that seems quite likely to me :/

Lea_Lacroix_WMDE added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).May 9 2019, 11:59 AM
Lea_Lacroix_WMDE mentioned this in T172937: Cursor jumping to next field and overlapping of menus.
gerritbot added a comment.May 9 2019, 12:01 PM

Change 509043 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Revert "Close entityselector after selecting exact match"

https://gerrit.wikimedia.org/r/509043

gerritbot added a project: Patch-For-Review.May 9 2019, 12:01 PM
Lucas_Werkmeister_WMDE claimed this task.May 9 2019, 12:01 PM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
gerritbot added a comment.May 9 2019, 12:42 PM

Change 509043 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Revert "Close entityselector after selecting exact match"

https://gerrit.wikimedia.org/r/509043

gerritbot added a comment.May 9 2019, 12:48 PM

Change 509050 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@wmf/1.34.0-wmf.4] Revert "Close entityselector after selecting exact match"

https://gerrit.wikimedia.org/r/509050

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.5; 2019-05-14).May 9 2019, 1:00 PM
gerritbot added a comment.May 9 2019, 11:32 PM

Change 509050 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.34.0-wmf.4] Revert "Close entityselector after selecting exact match"

https://gerrit.wikimedia.org/r/509050

Stashbot added a comment.May 9 2019, 11:41 PM

Mentioned in SAL (#wikimedia-operations) [2019-05-09T23:41:14Z] <ebernhardson@deploy1001> Synchronized php-1.34.0-wmf.4/extensions/Wikibase/view/resources/jquery/wikibase/jquery.wikibase.entityselector.js: T172937 T222346 Revert Close entityselector after selecting exact match (duration: 00m 51s)

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.May 9 2019, 11:50 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.4; 2019-05-07); removed MW-1.34-notes (1.34.0-wmf.5; 2019-05-14).May 10 2019, 12:00 AM
Lydia_Pintscher closed this task as Resolved.May 13 2019, 8:48 AM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

\o/

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL