Description

Details

	Subject	Repo	Branch	Lines +/-
	Use OO.ui.confirm for discard changes	mediawiki/extensions/WikibaseMediaInfo	master	+26 -9

Customize query in gerrit

Event Timeline

Esanders created this task.May 2 2019, 2:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 2 2019, 2:56 PM

Esanders edited projects, added Structured Data Engineering; removed StructuredDataOnCommons.May 2 2019, 2:58 PM

Restricted Application added a project: Multimedia. · View Herald TranscriptMay 2 2019, 2:58 PM

Esanders renamed this task from Use OO.ui.alert instead of system alert when pressing "cancel" to Use OO.ui.confirm instead of mw.confirmCloseWindow.trigger when pressing "cancel".May 2 2019, 3:16 PM

Change 507818 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/WikibaseMediaInfo@master] Use OO.ui.confirm for discard changes

https://gerrit.wikimedia.org/r/507818

gerritbot added a project: Patch-For-Review.May 2 2019, 3:29 PM

• Ramsey-WMF moved this task from To Do to Doing on the Structured Data Engineering board.May 6 2019, 4:52 PM

Sounds good to me.

Change 507818 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Use OO.ui.confirm for discard changes

https://gerrit.wikimedia.org/r/507818

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.5; 2019-05-14).May 7 2019, 10:00 PM

New dialog:

Screenshot 2019-05-07 at 15.25.36.png (123×300 px, 11 KB)

• Ramsey-WMF moved this task from Untriaged to Tracking on the Multimedia board.May 10 2019, 5:03 PM

Verified on Production.

	F28960312: Screenshot 2019-05-07 at 15.25.36.png
	May 7 2019, 10:28 PM

Use OO.ui.confirm instead of mw.confirmCloseWindow.trigger when pressing "cancel"Closed, ResolvedPublicActions

Description

Details

Event Timeline

Use OO.ui.confirm instead of mw.confirmCloseWindow.trigger when pressing "cancel"
Closed, ResolvedPublic
Actions