As noted by @Urbanecm, it's possible for someone who is on the mentors list to visit Special:Homepage and be assigned to themselves as a mentor.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Mentor and mentee should never be the same user | mediawiki/extensions/GrowthExperiments | master | +43 -5 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Rileych | T213990 [EPIC] Growth: Newcomer homepage | |||
| Resolved | SBisson | T216631 Homepage: mentorship module | |||
| Resolved | Urbanecm_WMF | T222400 Homepage: users on mentors list who use Special:Homepage should not be assigned themselves as mentors |
Event Timeline
Comment Actions
Change 507876 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] Mentor and mentee should never be the same wikipedian
Comment Actions
Can we filter by status? Autoconfirmed users are experienced enough (in theory) not to need a mentor.
Comment Actions
We can assign a mentor only for non-autoconfirmed users, that's not a (technical) problem. However, autoconfirmed is very low level of experience, I would vote for them to have a mentor. Either way, it should be probably @MMiller_WMF's decision and for certain a different task :).
Comment Actions
Change 507876 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] Mentor and mentee should never be the same user
Comment Actions
Change 507876 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Mentor and mentee should never be the same user
Comment Actions
Checked in betalabs. When a user activate the Homepage, and the mentor list has only the user's name on it - the mentor ship module will not be displayed.
To follow up on the comment from @Urbanecm:
I agreed that some decision should be made to what user categories we assign a mentor. The Homepage can be enabled by any type of users - and many users may be experienced users who do not need (or want) mentorship. Right now it's not possible to have Homepage without the mentorship module.
Comment Actions
Thank you @Urbanecm and @Etonkovidova. I think we are good on this bug for now. Although I agree that many users do not need mentors, there are two reasons not to change the behavior at this time:
- This feature is built exclusively for newcomers right now. While we all see potential in having a homepage for experienced editors, that would be a different set of work with a different set of goals that we can think about another time.
- I don't expect there to be many negative consequences of experienced users seeing their homepage with a mentor. If anything, it may make some of them realize that it is possible to be a mentor and ask how to sign up.