Page MenuHomePhabricator
Create Task
Maniphest T222441

TwoColConflict browser tests are flapping
Closed, ResolvedPublic
Actions

Description

This test is timing out often:

https://integration.wikimedia.org/ci/job/mwselenium-quibble-docker/12165/consoleFull

13:19:58     And I have dismissed the help dialog                         # features/support/step_definitions/help_steps.rb:5
13:19:58       timed out after 30 seconds, waiting for true condition on #<Watir::Browser:0x..f86bf2e818b1a998a url="http://127.0.0.1:9412/index.php?title=TwoColConflict_Test_Page&action=submit" title="Edit conflict: TwoColConflict Test Page - TestWiki"> (Watir::Wait::TimeoutError)
13:19:58       ./features/support/pages/edit_conflict_page.rb:54:in `/^The help dialog is hidden$/'
13:19:58       features/filter_options.feature:11:in `And I have dismissed the help dialog'
13:19:58     And I select the show unchanged text option                  # features/support/step_definitions/edit_conflict_steps.rb:92
13:19:58     Then The two column edit conflict screen should be shown     # features/support/step_definitions/edit_conflict_steps.rb:1
13:19:58     And Section for full common changes should be there          # features/support/step_definitions/edit_conflict_steps.rb:52
13:19:58     And Section for collapsed common changes should not be there # features/support/step_definitions/edit_conflict_steps.rb:76

Related Objects
Search...

Event Timeline

awight created this task.May 3 2019, 11:27 AM
WMDE-Fisch added subscribers: thiemowmde, WMDE-Fisch.May 6 2019, 9:53 AM

These are the ruby selenium tests for the "old" UI. I think we are at a point were we also could just disable them because it seems very unlikely that we will keep that UI in the codebase. - Opinions @thiemowmde ?

thiemowmde added a comment.May 6 2019, 10:12 AM

We want to remove the old interface entirely, and are waiting for green light from our communication team as well as product manager. We will remove these tests as well then.

I would disable them only if they fail with every single patch. But this doesn't seem to be the case. Failures are rare and usually gone when re-triggering Jenkins.

WMDE-Fisch added a comment.May 6 2019, 1:54 PM
In T222441#5159391, @thiemowmde wrote:

We want to remove the old interface entirely, and are waiting for green light from our communication team as well as product manager. We will remove these tests as well then.

I would disable them only if they fail with every single patch. But this doesn't seem to be the case. Failures are rare and usually gone when re-triggering Jenkins.

Sounds fine then. Also since we're not adding to much things in the near future before we will remove the old UI.

• Lea_WMDE added a parent task: T222714: Remove the code for the first interface .May 14 2019, 9:04 AM
thiemowmde closed this task as Resolved.May 29 2019, 6:28 PM
thiemowmde claimed this task.

Resolved with https://gerrit.wikimedia.org/r/511754: the failing test doesn't exist any more.

thiemowmde mentioned this in T208994: Flaky TwoColConflict test "The help dialog is visible" (mwselenium).May 29 2019, 6:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits