Page MenuHomePhabricator

TwoColConflict browser tests are flapping
Closed, ResolvedPublic

Description

This test is timing out often:

https://integration.wikimedia.org/ci/job/mwselenium-quibble-docker/12165/consoleFull

13:19:58     And I have dismissed the help dialog                         # features/support/step_definitions/help_steps.rb:5
13:19:58       timed out after 30 seconds, waiting for true condition on #<Watir::Browser:0x..f86bf2e818b1a998a url="http://127.0.0.1:9412/index.php?title=TwoColConflict_Test_Page&action=submit" title="Edit conflict: TwoColConflict Test Page - TestWiki"> (Watir::Wait::TimeoutError)
13:19:58       ./features/support/pages/edit_conflict_page.rb:54:in `/^The help dialog is hidden$/'
13:19:58       features/filter_options.feature:11:in `And I have dismissed the help dialog'
13:19:58     And I select the show unchanged text option                  # features/support/step_definitions/edit_conflict_steps.rb:92
13:19:58     Then The two column edit conflict screen should be shown     # features/support/step_definitions/edit_conflict_steps.rb:1
13:19:58     And Section for full common changes should be there          # features/support/step_definitions/edit_conflict_steps.rb:52
13:19:58     And Section for collapsed common changes should not be there # features/support/step_definitions/edit_conflict_steps.rb:76

Event Timeline

awight created this task.May 3 2019, 11:27 AM

These are the ruby selenium tests for the "old" UI. I think we are at a point were we also could just disable them because it seems very unlikely that we will keep that UI in the codebase. - Opinions @thiemowmde ?

We want to remove the old interface entirely, and are waiting for green light from our communication team as well as product manager. We will remove these tests as well then.

I would disable them only if they fail with every single patch. But this doesn't seem to be the case. Failures are rare and usually gone when re-triggering Jenkins.

We want to remove the old interface entirely, and are waiting for green light from our communication team as well as product manager. We will remove these tests as well then.

I would disable them only if they fail with every single patch. But this doesn't seem to be the case. Failures are rare and usually gone when re-triggering Jenkins.

Sounds fine then. Also since we're not adding to much things in the near future before we will remove the old UI.

thiemowmde closed this task as Resolved.Wed, May 29, 6:28 PM
thiemowmde claimed this task.

Resolved with https://gerrit.wikimedia.org/r/511754: the failing test doesn't exist any more.