Page MenuHomePhabricator
Create Task
Maniphest T222465

GrowthExperiments phan job fails on JsonSerializable
Closed, ResolvedPublic
Actions

Description

Starting a few hours ago, mwext-php70-phan-docker fails with the following error on all GrowthExperiments patches

includes/HelpPanel/QuestionRecord.php:7 PhanRedefinedInheritedInterface \GrowthExperiments\HelpPanel\QuestionRecord inherits abstract Interface \JsonSerializable declared at internal:0 which is also declared at ../../vendor/jakub-onderka/php-parallel-lint/src/JsonSerializable.php:4. This may lead to confusing errors.

This is currently blocking all merges.

Details

SubjectRepoBranchLines +/-
Fix phan job: ignore line using JsonSerializablemediawiki/extensions/GrowthExperimentsmaster+1 -0
Fix phan job: ignore line using JsonSerializablemediawiki/extensions/GrowthExperimentswmf/1.34.0-wmf.3+1 -0
Customize query in gerrit

Related Objects

Event Timeline

SBisson created this task.May 3 2019, 5:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2019, 5:00 PM
SBisson triaged this task as High priority.May 3 2019, 5:00 PM
SBisson moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.May 3 2019, 5:08 PM

Change 507994 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Fix phan job: ignore line using JsonSerializable

https://gerrit.wikimedia.org/r/507994

gerritbot added a project: Patch-For-Review.May 3 2019, 5:08 PM
SBisson mentioned this in rEGREb2cab6b65b40: Fix phan job: ignore line using JsonSerializable.May 3 2019, 5:10 PM
SBisson added a comment.May 3 2019, 5:15 PM

Apparently fixed in the library but not yet released: https://github.com/JakubOnderka/PHP-Parallel-Lint/issues/125

SBisson moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 3 2019, 5:15 PM
kostajh closed this task as Resolved.May 3 2019, 5:34 PM
SBisson reopened this task as Open.EditedMay 3 2019, 5:41 PM

The patch failed to merge because of a MobileFrontend selenium test: T222469: MobileFrontend selenium test: "User:<username> Check user page is editable" blocking merges on GrowthExperiments extension

gerritbot added a comment.May 3 2019, 6:03 PM

Change 507994 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix phan job: ignore line using JsonSerializable

https://gerrit.wikimedia.org/r/507994

SBisson closed this task as Resolved.May 3 2019, 6:42 PM

Now it's merged.

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 3 2019, 7:00 PM
gerritbot added a comment.May 6 2019, 6:20 PM

Change 508379 had a related patch set uploaded (by Catrope; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.3] Fix phan job: ignore line using JsonSerializable

https://gerrit.wikimedia.org/r/508379

Catrope mentioned this in rEGRE589af5126b0a: Fix phan job: ignore line using JsonSerializable.May 6 2019, 6:24 PM
gerritbot added a comment.May 6 2019, 6:37 PM

Change 508379 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.3] Fix phan job: ignore line using JsonSerializable

https://gerrit.wikimedia.org/r/508379

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.3; 2019-04-30); removed MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 6 2019, 7:00 PM
Urbanecm edited subscribers, added: Urbanecm_WMF; removed: Urbanecm.Aug 26 2020, 2:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL