Captions on UW doesn't warn you more than once if your input is over 250
Closed, ResolvedPublicBUG REPORT
Actions

Description

User story: N/A

We have this:
[Tested on Beta] When a user is on the Describe step, if a user enters a caption that exceeds the character limit, they get a warning. However if they edit it, and it is still too long, they do not get another warning, resulting in an error message when it confirms what's been uploaded successfully. Not only that, but as described in T222481, the user is not able to get to the next step (Add data) at all.

We want this:
A user should be warned before publishing files on the Describe step that the character limit is still exceeded.

Screenshots (if possible):

screencapture-commons-wikimedia-beta-wmflabs-org-wiki-Special-UploadWizard-2019-05-03-14_48_22.png (4×2 px, 1 MB)

Acceptance Criteria:

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/UploadWizard	master	+1 -1	Use Wikibase's actual max length for label

Customize query in gerrit

Related Objects

Mentioned Here: T222481: There's no way to go forward to Add Data if there's an error/warning of any sort

Event Timeline

• PDrouin-WMF created this task.May 3 2019, 9:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2019, 9:04 PM

• PDrouin-WMF updated the task description. (Show Details)May 3 2019, 9:04 PM

• PDrouin-WMF added a project: SDC Design.May 3 2019, 9:26 PM

• PDrouin-WMF moved this task from Backlog 📚 to Doing 📝 on the SDC Design board.May 3 2019, 9:52 PM

• Ramsey-WMF triaged this task as Medium priority.May 6 2019, 4:46 PM

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.

• Ramsey-WMF added projects: Structured Data Engineering, Structured-Data-Team-Current-Work, SDC-Statements (Depicts-Walking).

The actual issue here is that UW was configured to allow 255 characters (and it shows and continues to show a warning when you exceed that number), but Wikibase doesn't allow labels longer than 250 (not 255).
So anything with 251-255 characters ran into this issue...

I changed UW to have the same limit as WB

Change 509013 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Use Wikibase's actual max length for label

https://gerrit.wikimedia.org/r/509013

gerritbot added a project: Patch-For-Review.May 9 2019, 9:11 AM

matthiasmullie claimed this task.May 9 2019, 9:12 AM

matthiasmullie moved this task from To Do to Code Review on the Structured-Data-Team-Current-Work board.

Change 509013 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Use Wikibase's actual max length for label

https://gerrit.wikimedia.org/r/509013

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.5; 2019-05-14).May 9 2019, 7:00 PM

Cparle moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.May 10 2019, 11:53 AM

• Ramsey-WMF moved this task from To Do to Doing on the Structured Data Engineering board.May 10 2019, 5:07 PM

• PDrouin-WMF moved this task from Doing 📝 to Done/Handed off 📮 on the SDC Design board.May 15 2019, 3:09 PM

Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 3:27 PM

• Ramsey-WMF moved this task from Needs QA to Verify on Production on the Structured-Data-Team-Current-Work board.May 23 2019, 11:33 PM