Page MenuHomePhabricator
Create Task
Maniphest T222483

Captions on UW doesn't warn you more than once if your input is over 250
Open, NormalPublicBug
Actions

Description

User story: N/A

We have this:
[Tested on Beta] When a user is on the Describe step, if a user enters a caption that exceeds the character limit, they get a warning. However if they edit it, and it is still too long, they do not get another warning, resulting in an error message when it confirms what's been uploaded successfully. Not only that, but as described in T222481, the user is not able to get to the next step (Add data) at all.

We want this:
A user should be warned before publishing files on the Describe step that the character limit is still exceeded.

Screenshots (if possible):

Acceptance Criteria:

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2019, 9:04 PM
PDrouin-WMF updated the task description. (Show Details)May 3 2019, 9:04 PM
Ramsey-WMF triaged this task as Normal priority.May 6 2019, 4:46 PM
Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.
Ramsey-WMF added projects: SDC Engineering, Multimedia-Current-Work, SDC-Statements (Depicts-Walking).
matthiasmullie added a subscriber: matthiasmullie.EditedMay 9 2019, 8:41 AM

The actual issue here is that UW was configured to allow 255 characters (and it shows and continues to show a warning when you exceed that number), but Wikibase doesn't allow labels longer than 250 (not 255).
So anything with 251-255 characters ran into this issue...

I changed UW to have the same limit as WB

gerritbot added a comment.May 9 2019, 9:11 AM

Change 509013 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Use Wikibase's actual max length for label

https://gerrit.wikimedia.org/r/509013

matthiasmullie claimed this task.May 9 2019, 9:12 AM
matthiasmullie moved this task from To Do to Code Review on the Multimedia-Current-Work board.
gerritbot added a comment.May 9 2019, 6:28 PM

Change 509013 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Use Wikibase's actual max length for label

https://gerrit.wikimedia.org/r/509013

Ramsey-WMF moved this task from To Do to Doing on the SDC Engineering board.May 10 2019, 5:07 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL