Page MenuHomePhabricator
Create Task
Maniphest T222489

Visual diffs not showing in mobile VE (when visual section editing is disabled)
Closed, ResolvedPublic
Actions

Description

Issue overview

Unable to view "👁 Visual" diff in mobile VE.

Expected behavior

  1. Make an edit in mobile VE to https://en.m.wikipedia.org/wiki/List_of_regions_of_the_United_States
  2. Tap "✓" in toolbar
  3. Tap "Publish"
    • Arrive at "Save your changes view"
  4. Compose edit summary
  5. Tap "Review your changes"
    • Arrive at "Review your changes view"
  6. Make sure "visual" diffs are selected
  7. Visual diff is displayed

Actual behavior

  1. Make an edit in mobile VE to https://en.m.wikipedia.org/wiki/List_of_regions_of_the_United_States
  2. Tap "✓" in toolbar
  3. Tap "Publish"
    • Arrive at "Save your changes view"
  4. Compose edit summary
  5. Tap "Review your changes"
    • Arrive at "Review your changes view"
  6. Make sure "visual" diffs are selected

7) Visual diff is displayed ⚠️ Loading overlay loops endlessly.

  • This video demonstrates the "Actual behavior" described in the steps above.

Enviornment

  • Device: iPhone Xs
  • OS: iOS 12.2
  • Browser: Safari
  • Internet connection: tested on both Wifi and LTE

Details

SubjectRepoBranchLines +/-
Fix diffs in non-section-editing modemediawiki/extensions/VisualEditorwmf/1.34.0-wmf.3+1 -1
Fix diffs in non-section-editing modemediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• ppelberg created this task.May 3 2019, 10:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2019, 10:23 PM
• ppelberg renamed this task from Visual diffs not loading in mobile VE to Visual diffs not showing in mobile VE.May 3 2019, 10:24 PM
• ppelberg updated the task description. (Show Details)
• ppelberg updated the task description. (Show Details)
• ppelberg mentioned this in T221289: [Regression pre-wmf.2] Switching back from the diff panel to the save form on mobile VE makes the form go empty.May 3 2019, 10:32 PM
Ryasmeen subscribed.May 3 2019, 10:34 PM

@ppelberg: Could you specify which article you were editing? I can't reproduce this on my sandbox on production, so assuming this is not a generic issue.

• ppelberg updated the task description. (Show Details)May 3 2019, 10:41 PM
• ppelberg updated the task description. (Show Details)
In T222489#5157031, @Ryasmeen wrote:

@ppelberg: Could you specify which article you were editing? I can't reproduce this on my sandbox on production, so assuming this is not a generic issue.

For sure – it was this article: https://en.m.wikipedia.org/wiki/List_of_regions_of_the_United_States (updated the task's description as well).

Ryasmeen added a comment.May 3 2019, 11:05 PM
In T222489#5157048, @ppelberg wrote:
In T222489#5157031, @Ryasmeen wrote:

@ppelberg: Could you specify which article you were editing? I can't reproduce this on my sandbox on production, so assuming this is not a generic issue.

For sure – it was this article: https://en.m.wikipedia.org/wiki/List_of_regions_of_the_United_States (updated the task's description as well).

Thanks! :) Works fine on my device (iPhone5s) btw. I see a bit of a lag while opening that section though.

ScreenRecording_05-03-2019 15-52-36.mp42 MBDownload

• marcella edited projects, added VisualEditor (Current work); removed VisualEditor.May 6 2019, 3:13 PM
• marcella moved this task from Incoming to Investigating on the VisualEditor (Current work) board.
matmarex subscribed.May 6 2019, 5:16 PM

I can't reproduce on this page, but I ran into an exception when testing an unrelated thing on desktop:

TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.

…coming from the code added in rEVEDec6cbeaf5e49: Only diff <section> contents in section editing mode. Might be the same issue.

matmarex added a comment.EditedMay 6 2019, 5:18 PM

The mobile visual section editing A/B test is still running, right? Maybe that's why we get different results.

matmarex claimed this task.May 6 2019, 5:30 PM
gerritbot added a comment.May 6 2019, 5:41 PM

Change 508367 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Fix diffs in non-section-editing mode

https://gerrit.wikimedia.org/r/508367

gerritbot added a project: Patch-For-Review.May 6 2019, 5:41 PM
matmarex renamed this task from Visual diffs not showing in mobile VE to Visual diffs not showing in mobile VE (when visual section editing is disabled).May 6 2019, 5:42 PM
gerritbot added a comment.May 6 2019, 6:13 PM

Change 508367 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix diffs in non-section-editing mode

https://gerrit.wikimedia.org/r/508367

gerritbot added a comment.May 6 2019, 6:14 PM

Change 508374 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.34.0-wmf.3] Fix diffs in non-section-editing mode

https://gerrit.wikimedia.org/r/508374

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 6 2019, 7:00 PM
matmarex moved this task from Investigating to QA on the VisualEditor (Current work) board.May 6 2019, 8:02 PM

Looks like James is volunteering to backport the patch to production. Meanwhile, it should be testable on Beta.

• ppelberg added a comment.EditedMay 6 2019, 10:11 PM
In T222489#5161021, @matmarex wrote:

The mobile visual section editing A/B test is still running, right? Maybe that's why we get different results.

Good call, @matmarex. cc @Ryasmeen

Update

I just tested on my WMF account and re-tested on my personal account. I am now seeing visual diffs on both accounts, following the same steps listed in this task's description and with the same device/browser/OS configuration. Read: the issue doesn't seem to be present any more.

I also tested on beta (article linked below) and visual diffs are working there for me as well.

Summary:

AccountidSection editingIssue
personalevennot presentno issues – visual diffs are displayed
WMFoddpresentno issues – visual diffs are displayed

Beta article tested: https://en.m.wikipedia.beta.wmflabs.org/wiki/Dog

gerritbot added a comment.May 7 2019, 12:31 AM

Change 508374 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.34.0-wmf.3] Fix diffs in non-section-editing mode

https://gerrit.wikimedia.org/r/508374

Stashbot added a comment.May 7 2019, 12:38 AM

Mentioned in SAL (#wikimedia-operations) [2019-05-07T00:38:06Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.3/extensions/VisualEditor/modules/ve-mw/init/ve.init.mw.ArticleTarget.js: Hot-deploy fix for visual diffs on mobile in non-section mode T222489 (duration: 00m 53s)

Jdforrester-WMF edited projects, added VisualEditor-MediaWiki-Mobile, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30); removed MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review.May 7 2019, 12:42 AM
Jdforrester-WMF subscribed.

Back-ported to production.

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.May 7 2019, 5:59 AM
• ppelberg closed this task as Resolved.Jun 19 2019, 12:19 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 19 2019, 12:19 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL