Page MenuHomePhabricator

Add appropriate text to warning: ⧼visualeditor-viewpage-savewarning⧽
Closed, ResolvedPublic

Description

I just got the warning "⧼visualeditor-viewpage-savewarning⧽" when trying to switch from editing a section of a page in the source editor to editing the entire thing (by using the shortcut alt-shift-e) The warning has no text currently, and I couldn't track its source down, but it should be documented. I tried to recreate it, but it let me switch without the warning.

Event Timeline

DannyS712 created this task.May 5 2019, 2:36 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2019, 2:36 AM
marcella renamed this task from Undocumented warning: ⧼visualeditor-viewpage-savewarning⧽ to Add appropriate text to warning: ⧼visualeditor-viewpage-savewarning⧽ .May 6 2019, 6:07 PM

I've updated this task to be adding user-facing text to give an appropriate error message to the user. @DannyS712, if you're able to reproduce the steps to the error again, please file another task so we can investigate. Thank you!

Change 508396 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Fix abandon edit warning message

https://gerrit.wikimedia.org/r/508396

Change 508396 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix abandon edit warning message

https://gerrit.wikimedia.org/r/508396

I just got the warning "⧼visualeditor-viewpage-savewarning⧽" when trying to switch from editing a section of a page in the source editor to editing the entire thing (by using the shortcut alt-shift-e)

More generally, whenever you switch from editing a section to editing another section (when using the NWE). Easiest way to reproduce the warning is to go to a talk page, click "Edit source", type something, then click "New section".

I tried to recreate it, but it let me switch without the warning.

The warning is only shown if you've made any changes in the editor; if you didn't type anything, it will just switch to the other section immediately.

ppelberg closed this task as Resolved.Wed, Jun 19, 12:30 AM
ppelberg claimed this task.