Minor: don't test for "/" before autolink
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dan1wang
	May 6 2019, 1:35 AM

Description

in pegTokenizer.pegjs, we have

urltext = (
            & [/A-Za-z] al:autolink { return al; }

We should not start test for autolink when encountering a "/" because it will always be falsy:

autolink
  = ! <extlink>
    // this must be a word boundary, so previous character must be non-word
    ! { return /\w/.test(input[endOffset() - 1] || ''); }

Details

	Subject	Repo	Branch	Lines +/-
	Bump Parsoid to v0.12.0-a15	mediawiki/vendor	master	+1 K -641
	Don't start autolink matching at "/"	mediawiki/services/parsoid	master	+108 -116

Customize query in gerrit

Event Timeline

Dan1wang created this task.May 6 2019, 1:35 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2019, 1:35 AM

Change 508165 had a related patch set uploaded (by Dan1wang; owner: Dan1wang):
[mediawiki/services/parsoid@master] Make autolink matching more efficient (T222561)

https://gerrit.wikimedia.org/r/508165

gerritbot added a project: Patch-For-Review.May 6 2019, 4:24 AM

ssastry triaged this task as Low priority.May 8 2019, 3:40 PM

Change 508165 had a related patch set uploaded (by Aklapper; owner: Dan1wang):
[mediawiki/services/parsoid@master] Don't start autolink matching at "/"

https://gerrit.wikimedia.org/r/508165

LGoto moved this task from Needs Triage to Backlog on the Parsoid board.Feb 15 2020, 12:05 AM

LGoto moved this task from Backlog to Needs Investigation on the Parsoid board.May 21 2020, 6:15 PM

Arlolra claimed this task.May 21 2020, 6:29 PM

Change 508165 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Don't start autolink matching at "/"

https://gerrit.wikimedia.org/r/508165

Arlolra closed this task as Resolved.May 28 2020, 7:38 PM

Change 601428 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump Parsoid to v0.12.0-a15

https://gerrit.wikimedia.org/r/601428

Change 601428 merged by jenkins-bot:
[mediawiki/vendor@master] Bump Parsoid to v0.12.0-a15

https://gerrit.wikimedia.org/r/601428

Minor: don't test for "/" before autolinkClosed, ResolvedPublicActions

Description

Details

Event Timeline

Minor: don't test for "/" before autolink
Closed, ResolvedPublic
Actions