Page MenuHomePhabricator
Create Task
Maniphest T222596

EntitySchema\Tests\DataAccess\ArrayRevisionLookup must be compatible with RevisionLookup
Closed, ResolvedPublic
Actions

Description

Currently EntitySchema tests yield:

08:55:35 Fatal error: Declaration of EntitySchema\Tests\DataAccess\ArrayRevisionLookup::getPreviousRevision() must be compatible with that of MediaWiki\Revision\RevisionLookup::getPreviousRevision() in /workspace/src/extensions/EntitySchema/tests/phpunit/DataAccess/ArrayRevisionLookup.php on line 16
(https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/47529/console)

Details

SubjectRepoBranchLines +/-
Adapt ArrayRevisionLookup to RevisionLookup changesmediawiki/extensions/EntitySchemamaster+6 -2
Customize query in gerrit

Event Timeline

hoo created this task.May 6 2019, 9:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2019, 9:56 AM
hoo moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 6 2019, 9:57 AM
gerritbot added a comment.May 6 2019, 10:11 AM

Change 508297 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/EntitySchema@master] Adapt ArrayRevisionLookup to RevisionLookup changes

https://gerrit.wikimedia.org/r/508297

gerritbot added a project: Patch-For-Review.May 6 2019, 10:11 AM
hoo moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 6 2019, 10:12 AM
Michael subscribed.May 6 2019, 10:19 AM

For the record, this was broken in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/507028

gerritbot added a comment.May 6 2019, 12:29 PM

Change 508297 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] Adapt ArrayRevisionLookup to RevisionLookup changes

https://gerrit.wikimedia.org/r/508297

hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 6 2019, 1:30 PM
Michael moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 10 2019, 11:20 AM
WMDE-leszek subscribed.May 16 2019, 10:18 AM

This seem to have been fixed. Therefore closing this ticket. Feel free to re-open if I missed something.

Ladsgroup removed a project: Patch-For-Review.May 22 2019, 9:17 AM
Michael closed this task as Resolved.May 24 2019, 12:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL