Page MenuHomePhabricator

Separate content styles from chrome styles
Open, NormalPublic


Consider separating content styles from chrome styles so it's easier for downstream to consume just content styles.
In PCS we are currently using skins.minerva.base.styles and skins.minerva.content.styles.
There are lots of sibling folders. I assume that these are only for chrome.
It would be nice to make this separation even clearer by either adding a new folder level or through naming. One possible way would be to change the name of skins.minerva.base.styles to skins.minerva.content.base.styles.

Event Timeline

bearND created this task.May 6 2019, 4:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
phuedx added a subscriber: phuedx.May 9 2019, 10:40 AM

AIUI this isn't High priority but a nice to have. Is that correct, @bearND?

phuedx triaged this task as Normal priority.May 9 2019, 10:41 AM
phuedx moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.
bearND added a comment.EditedMay 9 2019, 3:25 PM

@phuedx Yes, that is correct. I've mainly brought it up since you are doing various refactoring, and it might fit into the theme. :)