Directive in table attribute position breaks attribute parsing
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Dvorapa
	May 6 2019, 5:41 PM

Description

See for example https://cs.wikipedia.org/w/index.php?title=%C5%A0ablona:ZSB&action=edit&lintid=2051988

There is nothing wrong about it, but linter still does mark it as fostered.

Related Objects

Mentioned Here: T207956: Token stream patcher table start retokenizing doesn't handle non-string tokens in table attribute position
T162919: Disable fostering lint error for category and other transparent tags

Event Timeline

Dvorapa created this task.May 6 2019, 5:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2019, 5:41 PM

Izno moved this task from Backlog to Parsoid on the MediaWiki-extensions-Linter board.Feb 18 2020, 3:05 PM

Aklapper edited projects, added Parsoid; removed Parsoid-Linter.Feb 29 2020, 5:13 PM

Arlolra moved this task from Needs Triage to Backlog on the Parsoid board.Mar 2 2020, 4:28 PM

Arlolra moved this task from Backlog to Linting on the Parsoid board.

Another example:

https://en.wikipedia.org/w/index.php?title=Template:World_Indoor_Tour_Track&oldid=951038947

This template is fine, but it shows a Fostered content Linter error. I think the solution is for Linter to ignore noinclude tags, though there might be side effects I am not aware of.

Another example:

https://en.wikipedia.org/w/index.php?title=Template:World_Indoor_Tour_Track&oldid=951038947

It looks like this one was "fixed" with this edit,
https://en.wikipedia.org/w/index.php?title=Template:World_Indoor_Tour_Track&type=revision&diff=1032255248&oldid=982460659&diffmode=source

I think the solution is for Linter to ignore noinclude tags, though there might be side effects I am not aware of.

Parsoid already has code to ignore fostered noinclude metas, introduced in T162919

The problem is that table attribute parsing is broken in the face of a closing noinclude tag,
https://cs.wikipedia.org/api/rest_v1/page/html/%C5%A0ablona:ZSB
https://en.wikipedia.org/api/rest_v1/page/html/Template:World_Indoor_Tour_Track/951038947

This is a Parsoid rendering issue.

Arlolra renamed this task from fostered should ignore <noinclude> tags to Directive in table attribute position breaks attribute parsing.Sep 15 2021, 7:25 PM

Arlolra triaged this task as Medium priority.

Arlolra moved this task from Linting to Bugs & Crashers on the Parsoid board.

It sounds like this is from T207956, maybe

Arlolra merged a task: T291804: <onlyinclude> in attribute positions of table nodes not handled correctly in Parsoid.Sep 27 2021, 3:10 PM

Arlolra added a subscriber: ssastry.

ssastry added a project: Parsoid-Read-Views (Phase 1 - DiscussionTools support).Sep 29 2021, 9:54 PM

ssastry moved this task from Backlog to Mostly edge cases on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.Jan 26 2022, 7:42 PM